Tooltip now closes properly when hovering the overlay without hovering the tooltip

alexasselin008 commented 1 year ago

Summary

Here is 3 scenario of how the tooltip works before the fix

MouseEnter on trigger -> Tooltip shows
MouseLeave on Trigger -> MouseEnter on white background -> Tooltip disappear because of the event handlers on the trigger.

MouseEnter on trigger -> Tooltip shows
MouseLeave on trigger -> MouseEnter Overlay -> Trigger's Event handler ignore the mouseLeave because it's on the overlay. and that is allowed
MouseEnter on Tooltip -> Tooltip stays open
MouseLeave Tooltip -> Tooltip closes because of the event handlers on the tooltip

MouseEnter on trigger -> Tooltip shows
MouseLeave on Trigger -> MouseEnter on Overlay -> Trigger's Event handler ignore the mouseLeave because it's on the overlay. and that is allowed
MouseLeave Overlay -> MouseEnter on white background -> since the mouse never went in the tooltip, the popup stays open because nobody listen to overlay mouseLeave. The bug is here

Instead of handling the dismiss inside the tooltip, i'm handling it in the trigger

netlify[bot] commented 1 year ago

Name	Link
Latest commit	6f1abbe905505b731fcb71773f5b0aa42fb67304
Latest deploy log	https://app.netlify.com/sites/sg-storybook/deploys/63f4fd8336c6a900080b44b5
Deploy Preview	https://deploy-preview-1153--sg-storybook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	6f1abbe905505b731fcb71773f5b0aa42fb67304
Latest deploy log	https://app.netlify.com/sites/sg-orbit/deploys/63f4fd83483b5d000806f7da
Deploy Preview	https://deploy-preview-1153--sg-orbit.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.