gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
101 stars 37 forks source link

added html attribute to prevent dashlane from adding its icon on date… #1161

Closed fraincs closed 1 year ago

fraincs commented 1 year ago

Issue:

DatePicker Input is not wide enough clashing with password managers #953

Summary

Dashlane was adding it's icon on date inputs pretending it was a birth date input!

What I did

Added a data attribute to make Dashlane behave.

How to test

Visit the date input / date range input doc page with Dashlane installed.

netlify[bot] commented 1 year ago

Deploy Preview for sg-orbit ready!

Name Link
Latest commit 70a0e85f96f3f97c0655817c7259c48b24244a90
Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/63fcd17484ff380008f7a223
Deploy Preview https://deploy-preview-1161--sg-orbit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for sg-storybook ready!

Name Link
Latest commit 70a0e85f96f3f97c0655817c7259c48b24244a90
Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/63fcd17442d0100008050c70
Deploy Preview https://deploy-preview-1161--sg-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.