gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
101 stars 37 forks source link

fix: Remove fill color from icons #1162

Closed tjosepo closed 1 year ago

tjosepo commented 1 year ago

Summary

The fill value was hardcoded in the SVG, which made it impossible to overwrite the color, and made the icon not adapt to dark mode.

alexasselin008 commented 1 year ago

Thank you for the PR!.

The generated-icons folder is full of component auto generated when generating the react component from the SVgs. Modifiing this file means next build its going to be overwritten.

Also, looking at the svgs, multiple icons have a fill icon so they probably need to be fixed as well. @fraincs can you take a look a this? image

netlify[bot] commented 1 year ago

Deploy Preview for sg-orbit ready!

Name Link
Latest commit e2791d4c90c3b30b9e99401a2e9378f1fd9ee9a3
Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/63fd1d2e19f672000853e2a9
Deploy Preview https://deploy-preview-1162--sg-orbit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for sg-storybook ready!

Name Link
Latest commit e2791d4c90c3b30b9e99401a2e9378f1fd9ee9a3
Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/63fd1d2edc21be00085db50a
Deploy Preview https://deploy-preview-1162--sg-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

alexasselin008 commented 1 year ago

You can check/test all icons here:

https://sg-storybook.netlify.app/?path=/docs/chromatic-icons--icon-folder-major by toggling the dark mode

fraincs commented 1 year ago

@tjosepo can you fix those while at it?

tjosepo commented 1 year ago

I went ahead and removed the fill="none" attribute on the icons. Seems like they were unecessary, and it made previewing the icons harder.