Closed tjosepo closed 1 year ago
Thank you for the PR!.
The generated-icons folder is full of component auto generated when generating the react component from the SVgs. Modifiing this file means next build its going to be overwritten.
Also, looking at the svgs, multiple icons have a fill icon so they probably need to be fixed as well. @fraincs can you take a look a this?
Name | Link |
---|---|
Latest commit | e2791d4c90c3b30b9e99401a2e9378f1fd9ee9a3 |
Latest deploy log | https://app.netlify.com/sites/sg-orbit/deploys/63fd1d2e19f672000853e2a9 |
Deploy Preview | https://deploy-preview-1162--sg-orbit.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Name | Link |
---|---|
Latest commit | e2791d4c90c3b30b9e99401a2e9378f1fd9ee9a3 |
Latest deploy log | https://app.netlify.com/sites/sg-storybook/deploys/63fd1d2edc21be00085db50a |
Deploy Preview | https://deploy-preview-1162--sg-storybook.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
You can check/test all icons here:
https://sg-storybook.netlify.app/?path=/docs/chromatic-icons--icon-folder-major by toggling the dark mode
@tjosepo can you fix those while at it?
I went ahead and removed the fill="none"
attribute on the icons. Seems like they were unecessary, and it made previewing the icons harder.
Summary
The
fill
value was hardcoded in the SVG, which made it impossible to overwrite the color, and made the icon not adapt to dark mode.