added a fill test for icons to prevent issues where fill attribute is…

gsoft-inc / sg-orbit

The design system for ShareGate web apps.

https://orbit.sharegate.design

Apache License 2.0

101 stars 37 forks source link

Closed fraincs closed 1 year ago

fraincs commented 1 year ago

Issue:

We need a way to visually assert that all icons do not have fill attributes as it's impossible to override these if its the case.

Added a chromatic test that set the icons a yellow fill color and test them against a green background.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	d1cd0dd8e87c56105d1aa57596a9e0123012fe02
Latest deploy log	https://app.netlify.com/sites/sg-orbit/deploys/63fe260c92c7f10008f33487
Deploy Preview	https://deploy-preview-1165--sg-orbit.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	d1cd0dd8e87c56105d1aa57596a9e0123012fe02
Latest deploy log	https://app.netlify.com/sites/sg-storybook/deploys/63fe260c72b23c0008791094
Deploy Preview	https://deploy-preview-1165--sg-storybook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.