netlify[bot]
commented
1 year ago Deploy Preview for sg-storybook ready!
| Name | Link |
|---|---|
| Latest commit | 57e6fcd772071cb6aa171181814f75f1d42bb764 |
| Latest deploy log | https://app.netlify.com/sites/sg-storybook/deploys/63ff8979e36ed100087314d4 |
| Deploy Preview | https://deploy-preview-1168--sg-storybook.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Issue:
Summary
Size Icons support only one size it was counter intuitive to support size inherit only for the TextLink component. This PR is about removing size from Icon once and for all and use another strategy to support the icon in a small textLink component.
What I did
Removed size prop from Icon component. Reworked the textLink component to pass it's size to the link anchor as well as add come CSS to make sure inherit worked on the icon size in that situation.