gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
101 stars 37 forks source link

update non breaking dependencies #1200

Closed alexasselin008 closed 1 year ago

alexasselin008 commented 1 year ago

Summary

svgo: Followed migration guide: https://github.com/svg/svgo/releases/tag/v3.0.0 eslint-plugin-sort-destructure-keys: now order property with default values

Also brought back the validation on icon sizes. It found 2 issues

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 0211a859031077c925ef44307a12afc4c391557f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for sg-orbit ready!

Name Link
Latest commit 0211a859031077c925ef44307a12afc4c391557f
Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/641223314596380008be1c64
Deploy Preview https://deploy-preview-1200--sg-orbit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for sg-storybook ready!

Name Link
Latest commit 0211a859031077c925ef44307a12afc4c391557f
Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/64122331e281a300085b0363
Deploy Preview https://deploy-preview-1200--sg-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

alexasselin008 commented 1 year ago

The updates reveilled 2 bugs in our icons. This is what is breaking the build (on purpose)