Closed tjosepo closed 1 year ago
Latest commit: bef25c872e92c793d1490d7269fac2d7d85a8e4b
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | bef25c872e92c793d1490d7269fac2d7d85a8e4b |
Latest deploy log | https://app.netlify.com/sites/sg-orbit/deploys/642b099fe816b400088f5169 |
Deploy Preview | https://deploy-preview-1208--sg-orbit.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Name | Link |
---|---|
Latest commit | bef25c872e92c793d1490d7269fac2d7d85a8e4b |
Latest deploy log | https://app.netlify.com/sites/sg-storybook/deploys/642b099f2579fb000773a0e4 |
Deploy Preview | https://deploy-preview-1208--sg-storybook.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Fixes #1207
Summary
aria-label
was missing on the spinner when using a loadingIconButton
, which threw a console error.What I did
I added an aria-label to the spinner.
How to test
Yes, I add a unit test to ensure the spinner has the aria-label attribute set.
No