Feature/1215 - Githubissues

gsoft-inc / sg-orbit

The design system for ShareGate web apps.

https://orbit.sharegate.design

Apache License 2.0

102 stars 37 forks source link

Feature/1215 #1216

Closed fraincs closed 1 year ago

fraincs commented 1 year ago

Issue:

Summary

🐛 Illustration component as a child of a TileLink component automatically inheriting rounded corners #1215

What I did

Unset the border-radius on TileLink illustrations. Added Chromatic tests.

How to test

Test this in the demo in the documentation or check the Chromatic tests.

<TileLink orientation="horizontal">
    <Illustration backgroundColor="alias-accent-light">
        <Image src={Planet} width="100px" alt="Planet" />
    </Illustration>
    <Heading>Buy a ticket</Heading>
    <Content>
        Tickets are not refundable and not transferable. A confirmation email will be sent within
        the next few minutes
    </Content>
</TileLink>

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: b68f6ff46be74d35962c9b2950ca3eadee79c8bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | -------------------- | ----- | | @orbit-ui/components | Patch | | @sharegate/orbit-ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for sg-orbit ready!

Name	Link
Latest commit	b68f6ff46be74d35962c9b2950ca3eadee79c8bc
Latest deploy log	https://app.netlify.com/sites/sg-orbit/deploys/64638e8ed60627000892d473
Deploy Preview	https://deploy-preview-1216--sg-orbit.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.