search

gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
101 stars 37 forks source link

❗ XL breakpoint seems a little arbitrary. Should we use 1440px instead? #1218

Closed LaurentDario closed 1 year ago

LaurentDario commented 1 year ago

Description

In our work, we would like to use a 1440px breakpoint, but Orbit exposes 1280px for lg and 1536px for xl, but it feels like that last one is a little arbitrary. Would we be open to the idea of changing it for 1440px?

alexasselin008 commented 1 year ago

Could you describe a bit more the issue it causes you, just so we have a trace of why we are changing it?

LaurentDario commented 1 year ago

There is no real issue per se, more of a need. On ShareGate Management, we are currently working on a new experience that would need to fall on 2 columns instead of 3 when the viewport gets too small to properly display the data. Currently our options are only 1280px and 1536px. 1280px is too small for our needs and still gives us a very tight window to display our data, and we just felt that 1536px was a little too large.

That's more of a suggestion to fit our needs, because we don't have the option to add a custom breakpoint to our Responsive props. We could also simply add a new breakpoint but then 1440px and 1536px would feel pretty close to each others.

LaurentDario commented 1 year ago
As discussed in our Orbit Sync: We will move the xl value to 1440px instead of 1536px and just drop the current XL value. New breakpoints should be: Size Media query
xs min-width: 640px
sm min-width: 768px
md min-width: 1024px
lg min-width: 1280px
xl min-width: 1440px
alexasselin008 commented 1 year ago

Closed in https://github.com/gsoft-inc/sg-orbit/pull/1219