Closed tjosepo closed 1 year ago
Latest commit: 67c8bfadd77bb5c78b4fac1112fba7c71607f7a3
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 67c8bfadd77bb5c78b4fac1112fba7c71607f7a3 |
Latest deploy log | https://app.netlify.com/sites/sg-orbit/deploys/64ecbf0da723040008d91bff |
Deploy Preview | https://deploy-preview-1227--sg-orbit.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 67c8bfadd77bb5c78b4fac1112fba7c71607f7a3 |
Latest deploy log | https://app.netlify.com/sites/sg-storybook/deploys/64ecbf0d0f80b400081c1dd5 |
Deploy Preview | https://deploy-preview-1227--sg-storybook.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@fraincs @tjosepo was there any Chromatic tests validating this? There should have been visual test coverage making sure this kind of issue doesn't get merge in the main branch.
Issue: #1226
Summary
Fixes this icon:
What I did
Made the background of the checkmark icon an actual background, instead of a
::before
pseudo-element. Move the checkmark inside the markup.How to test
Is this testable with Jest or Chromatic screenshots? Yes
Does this need an update to the documentation? No
If your answer is yes to any of these, please make sure to include it in your PR.