search

gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
102 stars 37 forks source link

🐛 DatePicker Input is not wide enough clashing with password managers #953

Closed fraincs closed 1 year ago

fraincs commented 2 years ago

Describe the bug

When a password manager adds it's icon it overlaps with the input inside the datePicker component.

image

Steps to reproduce

Using a password manager like Dashlane, visit the dateInput component.

Expected results

There is enough white space to acknowledge these kinds of situations.

fraincs commented 2 years ago

The width is the same as a default input, apart from setting the default input wider, I see no other options. except live with the fact that password managers will mess up inputs once in a while, which happens here and there on the internet.

fraincs commented 2 years ago
image

Otherwise a date input in a vertical form will render weirdly.

patricklafrance commented 1 year ago

I might be wrong, but I thought you already nailed this one?

fraincs commented 1 year ago

This was "nailed" then an edge case occured.

patricklafrance commented 1 year ago

Ok, are you planning on working on this in the next 6 months? @fraincs

fraincs commented 1 year ago

Yes, I need to discuss with a designer as our input default size would need to change. This could be done within the February month.

fraincs commented 1 year ago

The issue here is that acknowledging the issue would need to make the DateInput size wider, which would require to make all Select / TextInputs / PasswordInputs. After thinking about it I am open to another option which would be to as much possible tell password managers to ignore this field. I don't see a situation where we would want to autocomplete a date range input field.

patricklafrance commented 1 year ago

I would also be opened to such a solution but I think we already had this discussion and it's wasn't possible because there isn't any common specification to tell a password manager to ignore a field and Dashlane offered no escape hatches at the time.

According to this reddit post, there seems to be a way now with Dashlane by adding data-form-type: "other" to the input.

fraincs commented 1 year ago

This is what I saw too, and is why I'm leaning towards this option. We would ignore the few obscure passwords managers who don't provide a way to opt out.

On Mon, Jan 30, 2023, 16:57 Patrick Lafrance @.***> wrote:

I would also be opened to such a solution but I think we already discussed this solution and it's wasn't possible because there wasn't any common specification to tell a password manager to ignore a field and Dashlane offered no escape hatches to do so.

According to this reddit post https://www.reddit.com/r/Dashlane/comments/wnbwtc/stop_autofill/, there's seem to be a way with Dashlane now by adding data-form-type: "other" to the input.

— Reply to this email directly, view it on GitHub https://github.com/gsoft-inc/sg-orbit/issues/953#issuecomment-1409413409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYJIATMOWGOVMMUYICABDWVA2N7ANCNFSM5TKYKR2A . You are receiving this because you were mentioned.Message ID: @.***>