search

gsoft-inc / wl-chromado

Toolbox to use Chromatic with Azure DevOps
https://gsoft-inc.github.io/wl-chromado
Apache License 2.0
1 stars 1 forks source link

Unskip renovate/** branch #27

Open tjosepo opened 3 months ago

tjosepo commented 3 months ago

We just had an issue where a patch version of a package broke our application, because the pacakge mistakenly updated a peer dependency to a higher major version. This breaking change was not detected by our other static analysis tools (typescript, eslint, pnpm, etc.)

Chromatic didn't run because the it was a Renovate branch.

I think Renovate branch should not be skipped, as dependencies can change the UI.

patricklafrance commented 3 months ago

Could you provide additional information please about the error and also a short explanation about why you believe it should be Chromatic who detect this type of error? 🙏