gsoft-inc / wl-hopper

Hopper Design System
https://hopper.workleap.design/
Apache License 2.0
3 stars 2 forks source link

fixed an accessibility alert due to the provider not having the right value in dark mode #426

Closed fraincs closed 2 weeks ago

fraincs commented 2 weeks ago

Since navigate needs an HopperProvider to work, the current story was forcing a light colorScheme instead of using the parent colorScheme, causing an accessibility issue according to the Storybook plugin. This was not the case, the issue was that the light theme was applied to the dark mode.

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 0899fcf9ece63dedaa2fa01d22e7d6249a44f713

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 2 weeks ago

Deploy Preview for wl-hopper ready!

Name Link
Latest commit 0899fcf9ece63dedaa2fa01d22e7d6249a44f713
Latest deploy log https://app.netlify.com/sites/wl-hopper/deploys/66e8d61c4747840008721a89
Deploy Preview https://deploy-preview-426--wl-hopper.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 2 weeks ago

View Storybook