gsoft-inc / wl-hopper

Hopper Design System
https://hopper.workleap.design/
Apache License 2.0
3 stars 2 forks source link

[DS-392] - New Icon documentation page, New UI for composedComponents sections #495

Closed fraincs closed 1 month ago

fraincs commented 1 month ago
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 2b54ba33bca951659a7b77f3e3eec420c6d92314

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for wl-hopper ready!

Name Link
Latest commit 2b54ba33bca951659a7b77f3e3eec420c6d92314
Latest deploy log https://app.netlify.com/sites/wl-hopper/deploys/671115f4b41c660008301650
Deploy Preview https://deploy-preview-495--wl-hopper.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 month ago

View Storybook

alexasselin008 commented 1 month ago

image Something odd is happening here.

For this section, i would 1- remove Tag and TagList from the composed components. There defined in this file already, no need to point to it 2- Merge them all together

alexasselin008 commented 1 month ago

Can you pass all articles annd make sure that this pattern doesn't exist anymore: image

1- there is still bullet points for some reasons 2- under Composed Components, i only want a list of component, not another sub section