gsoft-inc / wl-orbiter

https://wl-orbiter-website.netlify.app
Apache License 2.0
1 stars 2 forks source link

[DS-288] Autocomplete fix #146

Closed victortrinh2 closed 1 month ago

victortrinh2 commented 1 month ago

Issue: Autocomplete in a Modal would overflow

Summary

Fix the issue where an Autocomplete in a Modal would overflow

If we're using the autocomplete in a Modal, the user will have to add the Overlay element of the modal to boundaryElement.

What I did

Added the option to add a boundaryElement to the Autocomplete and Listbox component.

How to test

If your answer is yes to any of these, please make sure to include it in your PR.

I tested by adding the boundary directly to the Listbox from the Autocomplete when it's inside a modal.

Screenshot 2024-09-23 at 10 01 27 AM

netlify[bot] commented 1 month ago

Deploy Preview for wl-orbiter-storybook ready!

Name Link
Latest commit 078beb29bee80cf3cf24389d0aaab4aa17a8c883
Latest deploy log https://app.netlify.com/sites/wl-orbiter-storybook/deploys/66f1cefbba8db7000881a9e4
Deploy Preview https://deploy-preview-146--wl-orbiter-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for wl-orbiter-website ready!

Name Link
Latest commit 078beb29bee80cf3cf24389d0aaab4aa17a8c883
Latest deploy log https://app.netlify.com/sites/wl-orbiter-website/deploys/66f1cefb95cf820008962547
Deploy Preview https://deploy-preview-146--wl-orbiter-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.