search

gsohler / openscad

OpenSCAD - The Programmers Solid 3D CAD Modeller
https://www.openscad.org
Other
14 stars 6 forks source link

Ensure proper extension is used in file save #3

Closed Matthieu-LAURENT39 closed 11 months ago

Matthieu-LAURENT39 commented 11 months ago

This was meant to be included in #2 , but i didn't push before it got merged, and you can't re-open a merged PR. I'm merging to python-pr3 since this is a direct follow-up, but my next pull requests will be to the python branch.

Anyways, this makes sure that the right extension is added to the filename no extension is provided. Before, it always defaulted to getSaveFileName.

gsohler commented 11 months ago

Hard to realize, how the compile error in ManifoldUtils relates to your change. Maybe you try to take it back just for a test. Generally you should try to surround all python stuff inside #ifdefs as much a possible to not show the python additions when its not selected during cmake.

Matthieu-LAURENT39 commented 11 months ago

The issue seems fixed, builds seem to work This should be good to merge now

gsohler commented 11 months ago

i think the macos-tests is solved. give me little time to find out