search

gsohler / openscad

OpenSCAD - The Programmers Solid 3D CAD Modeller
https://www.openscad.org
Other
26 stars 7 forks source link

Improve commenting logic #7

Closed Matthieu-LAURENT39 closed 1 year ago

Matthieu-LAURENT39 commented 1 year ago

This makes comments respect PEP8 by adding a single space after the # It also optimizes the previous comment changes

Matthieu-LAURENT39 commented 1 year ago

I originally wanted to optimize the comment logic more by adding the # at the correct indentation level, but that would require actually knowing the current indentation level, which is way too much of an overhead considering the low improvement it is

Matthieu-LAURENT39 commented 1 year ago

I just finished testing everything, this should be good to merge

Matthieu-LAURENT39 commented 1 year ago

Seems REALLY weird how it seemed to only fail on ubuntu-20.04, and it only started failing after a tiny change completely unrelated to the test Is there a possibility that this randomly failed?

Edit: I tried to run the failing test myself, and it worked without issue, this is definitely really weird... image Sadly i don't have write permissions on this repo, so i can't re-run the action myself. Could you please do it?

Another edit: I looked though the openscad repo, and it seems ubuntu-20.04 just fails some tests randomly sometimes, so it's probably a non-issue

gsohler commented 1 year ago

yes, the openscad repo on gthe CI build system experiences random fails on cpu extensive tests for quite some time. rerun often helps. Suspect shortage of ram of ulimit, but don't know exactly.