search

gsp-eeg / PyGSP2

Graph Signal Processing 2 in Python
https://pygsp2.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Fixed incompatibility issue with scipy function spatial.KDTree.query - [merged] #16

Closed lucaslanek closed 4 months ago

lucaslanek commented 8 months ago

In GitLab by @julioRodino on Mar 6, 2024, 17:34

Merges 1-fix-scipy-compatibility -> master

Closes #1

The issue with the spatial.KDTree.query was solved by replacing k=None with K=len(Xout). This returns the maximum number of neighbors. The ones with inf distance are then eliminated.

The function yields the same results as with using scipy version 1.7.3.

Further optimization can be made to fasten the code.

lucaslanek commented 8 months ago

In GitLab by @julioRodino on Mar 6, 2024, 17:34

requested review from @aweinstein

lucaslanek commented 6 months ago

In GitLab by @julioRodino on Apr 12, 2024, 14:18

mentioned in commit e8b7e9c9958582f32938861fafbff044707529e0