search

gsp-eeg / PyGSP2

Graph Signal Processing 2 in Python
https://pygsp2.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

28 move metro utils out of the examples folder #33

Closed lcortesg closed 2 months ago

aweinstein commented 2 months ago

I'm confused with this PR. I see a lot of name changes from PyGSP to PyGSP2 (which are OK) that are not related with the issue at hand. Are you killing two birds with one stone?

lcortesg commented 2 months ago

I'm confused with this PR. I see a lot of name changes from PyGSP to PyGSP2 (which are OK) that are not related with the issue at hand. Are you killing two birds with one stone?

This branch, 28 move metro utils out of the examples folder is itself a branch of 22 change basename folder to pygsp2, so the name changes are duplicated, it would be advisable to first merge the branch 22 change basename folder to pygsp2, and then branch 28 move metro utils out of the examples folder.

Also, branch 28 move metro utils out of the examples folder is tried and tested, it also has a passing build in PyPi.

lcortesg commented 2 months ago

Closed pull request, will open an updated one