search

gss / engine

GSS engine
http://gss.github.io
MIT License
2.86k stars 105 forks source link

border-radius not being respected in 1.0.0.rc1 #125

Open VinSpee opened 10 years ago

VinSpee commented 10 years ago

Hi!

I'm new to GSS, so I may be overlooking something here, but as far as I can tell, 1.0.0.rc1 is not respecting border radius settings.

Example that lead me to this issue:

I was building an experiment POC with GSS. I started with the current beta (this could be considered a use-case if it was intentionally removed):

http://codepen.io/VinSpee/pen/gbOevj?editors=110

Then I decided to upgrade to RC1 and update the code along with it and ended up with:

http://codepen.io/VinSpee/pen/ByavxN?editors=110

Here's a bare-minimum test-case:

http://codepen.io/VinSpee/pen/XJWwYG

Was this intentional? Or is it a bug? Or am I just missing something?

VinSpee commented 10 years ago

note: this doesn't work with the &[border-top-right-radius] == 10; syntax either.

paulyoung commented 10 years ago

Hey @VinSpee!

I can confirm that the shorthand of border-radius: == 10; does work but I don't think the longhand is implemented yet.

@Inviz and I have discussed long vs shorthand a little bit and how it sort-of works for margin and padding at the moment.

I think our intention is to support longhand and handle it properly.

VinSpee commented 10 years ago

Awesome, but the shorthand doesn't fully work as I understand it.

border-radius: == 10 20 40 60; also does not work, which is still shorthand correct?

paulyoung commented 10 years ago

Correct. I'm only aware of the example I gave working at the moment.

VinSpee commented 10 years ago

Cool, thanks. Here's another vote for the importance of this! Keep up the killer work - Looking forward to 1.0

Inviz commented 10 years ago

The more capable CSSOM system is in works. We'll be able to do that example with multiple values pretty soon. In fact the style matching/formatting is already in place, and it causes this problem. There's clearly a handling of border-radius properties, but there might be a bug. I'll spec it when I get to it.

Inviz commented 10 years ago

Thanks for bug report, indeed border radius family was not generated properly. I fixed it in the WIP branch, will be there in the next big release. Though we don't properly handle 2nd value of border radius yet. But its on my radar