search

gssapi / gss-ntlmssp

A complete implementation of the MS-NLMP documents as a GSSAPI mechanism
ISC License
30 stars 26 forks source link

Fix hostbased name #66

Closed simo5 closed 2 years ago

simo5 commented 2 years ago

Fixes #63

simo5 commented 2 years ago

@filipnavara hopefully this addresses the SPN issue. However it would be really nice to check that there are no regressions against a modern windows server given that I am fiddling with fields of the Traget Info that I haven't really touched before.

simo5 commented 2 years ago

Nice, I'm going to add just a couple of tests and then push it to master.

simo5 commented 2 years ago

Glad I added tests, found incorrect behavior with names like "", "@", "@foo.bar", ... @filipnavara do you have any tests with names like the above? ^^

filipnavara commented 2 years ago

@filipnavara do you have any tests with names like the above? ^^

Not at the moment but I will try it and cross check with other implementations!

simo5 commented 2 years ago

Alright, in the meanwhile I'll push this code as is, can always correct later if anything comes up about current behavior vs other implementations.

simo5 commented 2 years ago

Please note that the implementation will not currently set Traget Name in Target Info if a gss name is obtained that only includes a name and not a full spn ...