Open Uglymotha opened 2 weeks ago
A PR is good, the only question is whether it is possible to add a test in CI to make sure it stays working in the future.
I've been doing some looking around for the stale URL. Is this the issue that should be linked? https://pagure.io/SSSD/ding-libs/issue/3167
You can remove it if it is not an issue anymore
Currently it is not possible to cross compile gssproxy. This is due to two autoconf macros.
I propose to fix 1. by adding a cross compile action to AC_RUN_IFELSE displaying a warning message for the user to make sure libini_config supports extended INI_MS_DETECT and maybe also fix the stale URL (https://pagure.io/SSSD/ding-libs/pull-request/3172) in the current error message. Maybe the test can just be removed altogether.
2 Can be simply fixed by replacing AC_CHECK_FILE with an explicit if ! test .....
If you concur, I can prepare a PR.