search

gssapi / gssproxy

A proxy for GSSAPI | Docs at https://github.com/gssapi/gssproxy/tree/main/docs
Other
43 stars 28 forks source link

[0.9.0] doesn't allow disabled systemd #54

Closed udeved closed 2 years ago

udeved commented 2 years ago

With version 0.9.9, despite --with-initscript=none, the build errors out with

configure: error: conditional "HAVE_SYSTEMD_DAEMON" was never defined.
Usually this means the macro was only invoked conditionally.

I think this commit is responsible, but haven't tracked it down further. Might be the m4 systemd macro.

https://github.com/gssapi/gssproxy/commit/145c7cecb9d7aecb707c02995b0289b40a6df4d7

simo5 commented 2 years ago

Thanks for noticing, can you give me the compile error? It is probably just an incorrect use of if vs ifdef

udeved commented 2 years ago

It won't get to make phase, it fails at configure. We have neither systemd nor libsystemd present. I haven't tracked it down further, but it looks to me as if the systemd.m4 has no case for setting HAVE_SYSTEMD_DAEMON to 0 hence the error msg of undefined.

simo5 commented 2 years ago

The output from configure would help too. But I'll try to see if I can spot the issue without it

simo5 commented 2 years ago

I have reproduced

udeved commented 2 years ago

gssproxy-0.9.0-1-x86_64-build.log

simo5 commented 2 years ago

@udeved Are you able to apply the fix in #55 and let me know if it works for you?

you will need to run autoreconf -fi before running configure.

udeved commented 2 years ago

Yes, sure. Will report back.

udeved commented 2 years ago

Yes, that PR fixes the configure. :+1: log