Closed okapia closed 7 months ago
thanks, if you could add DCO it'd be nice
I've pushed a replacement commit with -s
for the Signed-off-by trailer to be added.
I didn't find any official text linked from gssproxy (or freeipa) so I'm assuming you're just using the same text as used by Linux (at https://developercertificate.org/). Perhaps this could be made explicit somewhere. Thanks
Thank you, yes github assumes the "standard" DCO as published by the Linux Kernel and we do the same.
Currently, the configure script is dumping a log message for the most recent commit into the middle of the output.
&> is non-standard for redirecting stdin and stderr. It is a short-hand copied from csh's >& by zsh and later bash. It is equivalent to >word 2>&1 which will also work in dash (/bin/sh on Debian) or other plain Bourne/POSIX shells.
I would perhaps question whether it might be better to check for the existence of a
.git
directory instead. Or for a git invocation that does less, perhaps rungit rev-parse --git-dir
, though that still needs the redirection. Or drop the autoconf test and handle things within the Makefile. Many projects use other forms such asgit describe --tags --long --abbrev=7
instead.