search

gstaff / flask-ngrok

A simple way to demo Flask apps from your machine.
Other
138 stars 58 forks source link

Incorrect chmod call #7

Closed aerospeace closed 4 years ago

aerospeace commented 4 years ago

Hi,

The permission to the ngrok download file are not correctly setup under Python 3.7. I solved this by modifiying line 29 of flask_ngrok.py with: os.chmod(executable, 777) to os.chmod(executable, 0o777) Sorry if I am not following the standard process for patching, I am not a developper.

Also a side not it would be good if flask-ngrok carry the kwargs arguments to the call of app.run.

aerospeace commented 4 years ago

Sorry was already fixed in a more up-to-date version