search

gsteele13 / spyview

1 stars 5 forks source link

Building spyview with gcc-6 #2

Closed akhuettel closed 7 years ago

akhuettel commented 7 years ago

Hi Gary,

here are a few changes that make spyview build with gcc-6 (and gcc-5).

Best from Regensburg, Andreas

gsteele13 commented 7 years ago

Thanks Andreas!

Do these compile still with earlier versions of gcc? (I want to be careful not to break the builds of others...)

I've just logged in and it seems I can "pull" your changes over via the web interface (I must say I still get confused about git terminology...) but I did want to check first...

Thanks, Gary

On 16 April 2017 at 20:42, Andreas K. Hüttel notifications@github.com wrote:

Hi Gary,

here are a few changes that make spyview build with gcc-6 (and gcc-5).

  • The standard libraries changed, leading to even more clashes with netpbm
  • C++14 is stricter in terms of casting types...

Best from Regensburg, Andreas

You can view, comment on, or merge this pull request online at:

https://github.com/gsteele13/spyview/pull/2 Commit Summary

  • Move mypam.h include from H file to C file since it's not part of the interface.
  • Remove implicit std:: usage, replace it either by spelling out all or using specific things
  • Casting a boolean literal to pointer is prohibited in C++14

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gsteele13/spyview/pull/2, or mute the thread https://github.com/notifications/unsubscribe-auth/APdA5i5LanezOki0vrfOCKVGokCEU2oYks5rwmEDgaJpZM4M-slQ .

-- Dr. Gary Steele Associate Professor Quantum Nanoscience Department, Room D103 Kavli Institute of Nanoscience Delft University of Technology Lorentzweg 1, 2628 CJ Delft The Netherlands Office: +31-15-278-3402 Mobile: +31-64-667-4938 Email: g.a.steele@tudelft.nl Website: http://steelelab.tudelft.nl

akhuettel commented 7 years ago

No worry, Github has its own confusing terminology (and some people claim it gets things "just wrong" compared to Git itself.) Yes, you should be able to merge it with the web interface.

About the older compiler versions, good question. I'm using some C++11 features so the compiler needs to do that. The last commit that I added now explicitly checks in configure for it.

I dont know about other compilers, but for GCC everything since 4.8.1 (released 2013) should work certainly, and some older ones probably too. See https://gcc.gnu.org/projects/cxx-status.html ... I'm testing with 4.9.4, 5.4.0 and 6.3 at the moment and every combination brings new surprises [correction: not just possibly but definitely two more commits follow].

Best, Andreas

gsteele13 commented 7 years ago

Thanks, perfect!

Cheers, Gary

On 19 April 2017 at 21:46, Andreas K. Hüttel notifications@github.com wrote:

No worry, Github has its own confusing terminology (and some people claim it gets things "just wrong" compared to Git itself.) Yes, you should be able to merge it with the web interface.

About the older compiler versions, good question. I'm using some C++11 features so the compiler needs to do that. The last commit that I added now explicitly checks in configure for it.

I dont know about other compilers, but for GCC everything since 4.8.1 (released 2013) should work certainly, and some older ones probably too. See https://gcc.gnu.org/projects/cxx-status.html ... I'm testing with 4.9.4, 5.4.0 and 6.3 at the moment and every combination brings new surprises, so possibly some more minor commits follow.

Best, Andreas

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gsteele13/spyview/pull/2#issuecomment-295409907, or mute the thread https://github.com/notifications/unsubscribe-auth/APdA5r7abXb9yNdxA5f3lP6deF7Ld014ks5rxmSagaJpZM4M-slQ .

-- Dr. Gary Steele Associate Professor Quantum Nanoscience Department, Room D103 Kavli Institute of Nanoscience Delft University of Technology Lorentzweg 1, 2628 CJ Delft The Netherlands Office: +31-15-278-3402 Mobile: +31-64-667-4938 Email: g.a.steele@tudelft.nl Website: http://steelelab.tudelft.nl