search

gsteph / groove-dl

A Grooveshark song downloader in Python
http://gsteph.github.io/groove-dl/
120 stars 30 forks source link

Outdated client #8

Closed DelusionalLogic closed 12 years ago

DelusionalLogic commented 12 years ago

The grooveshark servers return with an outdated client message, and doesn't return the result. updating the client value breaks the token.

DelusionalLogic commented 12 years ago

That's great :D i was just worried that it might not be sufficient. mind sharing the module when you are done compiling?

gsteph commented 12 years ago

Sure

gsteph commented 12 years ago

Aaaand here you go http://dl.dropbox.com/u/871134/_ssl.zip Place the lib in Python27\libs\ and the pyd in Python27\DLLs. Tested them with my GUI client and they work!

DelusionalLogic commented 12 years ago

Hooray, Great news.

I can get back to adding features to your script now, and using it for my own devious master plan.

Thank you, i think i'll mark this as closed now.

DelusionalLogic commented 12 years ago

I think I know why they hate us, we never reported as being done, this caused us to clog up the servers, and it might be why we get temp banned. we aren't actually banned, we just have too many outstanding requests we haven't reported as completed.

What we see as "unblocking" is actually the server dropping the request we never reported as being done.

I have fixed this on my side, just waiting to test it a bit more before i commit!

gsteph commented 12 years ago

That's great! Please make a pull request when you're done. I'll commit some of my changes first.

gsteph commented 12 years ago

I was actually thinking of pulling their ad once every download to be more ethical but was afraid to screw something up for them (if I don't get my headers right, I might get them banned from Adsense). I feel bad doing this.

DelusionalLogic commented 12 years ago

don't do it, they wont gain anything. this wont actually get then views or clicks, what i would advise is to add a message saying "powered by grooveshark" on every download, that seems more right to me.

gsteph commented 12 years ago

uh shouldn't that get them views ?.. the message wouldn't affect the downloaders. They're heartless xD How's the testing going ?