Number of dice rolled should be limited by number of armies

[jestelle]

Very nice simulator! Very fast. Much faster than the one at riskodds.com that I had used before.

However, I noticed your simulator doesn't deal with small numbers of armies correctly. e.g., the attacker needs at least 2 armies just to attack. And in that case, they can only roll 1 die. Similarly, when the defender is down to 1 army, they only should roll one die.

Your simulator always rolls 3 dice for the attacker and 2 for the defender.

I've been playing online risk for over a decade over here: https://sillysoft.net/lux/ Nice implementation, fun community.

I was looking for a dice odds calculator to settle some arguments ;-)

If I get around to it, I'll fix this bug and send you a pull request :D

[gstritar]

Hi, thanks for the email!

Are you sure?

Start Attacker Defender Winner End Status

1 2 v 1 1 1 Def. wins 1 1 v 1 Def. survives

12 3 v 2 3,3 5,3 Def. wins 2 1 v 2 Def. survives

Best, Grega

On 26 Oct 2020, at 19:41, Josh Estelle notifications@github.com wrote:

Very nice simulator! Very fast. Much faster than the one at riskodds.com that I had used before.

However, I noticed your simulator doesn't deal with small numbers of armies correctly. e.g., the attacker needs at least 2 armies just to attack. And in that case, they can only roll 1 die. Similarly, when the defender is down to 1 army, they only should roll one die.

Your simulator always rolls 3 dice for the attacker and 2 for the defender.

I've been playing online risk for over a decade over here: https://sillysoft.net/lux/ https://sillysoft.net/lux/ Nice implementation, fun community.

I was looking for a dice odds calculator to settle some arguments ;-)

If I get around to it, I'll fix this bug and send you a pull request :D

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gstritar/DiceRoll/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5IT6X6ISNFRAOWWSBG5QLSMW7GZANCNFSM4S7YRBOQ.

[jestelle]

Ah you're right.

The bug is smaller than I thought. The only problem looks like when you give the attacker only 1 army at the start, it doesn't do sensible things ;-) But I suppose that's an edge case that should just be considered bad input.

Josh

On Mon, Oct 26, 2020 at 11:48 AM Grega Stritar notifications@github.com wrote:

Hi, thanks for the email!

Are you sure?

Start Attacker Defender Winner End Status

1 2 v 1 1 1 Def. wins 1 1 v 1 Def. survives

12 3 v 2 3,3 5,3 Def. wins 2 1 v 2 Def. survives

Best, Grega

On 26 Oct 2020, at 19:41, Josh Estelle notifications@github.com wrote:

Very nice simulator! Very fast. Much faster than the one at riskodds.com that I had used before.

However, I noticed your simulator doesn't deal with small numbers of armies correctly. e.g., the attacker needs at least 2 armies just to attack. And in that case, they can only roll 1 die. Similarly, when the defender is down to 1 army, they only should roll one die.

Your simulator always rolls 3 dice for the attacker and 2 for the defender.

I've been playing online risk for over a decade over here: https://sillysoft.net/lux/ https://sillysoft.net/lux/ Nice implementation, fun community.

I was looking for a dice odds calculator to settle some arguments ;-)

If I get around to it, I'll fix this bug and send you a pull request :D

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/gstritar/DiceRoll/issues/1>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5IT6X6ISNFRAOWWSBG5QLSMW7GZANCNFSM4S7YRBOQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gstritar/DiceRoll/issues/1#issuecomment-716752171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX762IG24CIDRMVN6TST4LSMXABDANCNFSM4S7YRBOQ .

[gstritar]

Great, thank you for the interest, enjoy the game! :)

Best, Grega

On 26 Oct 2020, at 19:54, Josh Estelle notifications@github.com wrote:

Ah you're right.

The bug is smaller than I thought. The only problem looks like when you give the attacker only 1 army at the start, it doesn't do sensible things ;-) But I suppose that's an edge case that should just be considered bad input.

Josh

On Mon, Oct 26, 2020 at 11:48 AM Grega Stritar notifications@github.com wrote:

Hi, thanks for the email!

Are you sure?

Start Attacker Defender Winner End Status

1 2 v 1 1 1 Def. wins 1 1 v 1 Def. survives

12 3 v 2 3,3 5,3 Def. wins 2 1 v 2 Def. survives

Best, Grega

On 26 Oct 2020, at 19:41, Josh Estelle notifications@github.com wrote:

Very nice simulator! Very fast. Much faster than the one at riskodds.com that I had used before.

However, I noticed your simulator doesn't deal with small numbers of armies correctly. e.g., the attacker needs at least 2 armies just to attack. And in that case, they can only roll 1 die. Similarly, when the defender is down to 1 army, they only should roll one die.

Your simulator always rolls 3 dice for the attacker and 2 for the defender.

I've been playing online risk for over a decade over here: https://sillysoft.net/lux/ https://sillysoft.net/lux/ Nice implementation, fun community.

I was looking for a dice odds calculator to settle some arguments ;-)

If I get around to it, I'll fix this bug and send you a pull request :D

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/gstritar/DiceRoll/issues/1>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5IT6X6ISNFRAOWWSBG5QLSMW7GZANCNFSM4S7YRBOQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gstritar/DiceRoll/issues/1#issuecomment-716752171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX762IG24CIDRMVN6TST4LSMXABDANCNFSM4S7YRBOQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gstritar/DiceRoll/issues/1#issuecomment-716755193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5IT6XRMJH5GNGUA2ZWXSTSMXAX3ANCNFSM4S7YRBOQ.

[gstritar]

It is interesting, how the defender has the advantage on fighting e.g. 8:8.

But in a fight of 80:80, the attacker has a huge advantage. While in a 800:800 the defender does not even have the chance.

Best, Grega

On 26 Oct 2020, at 19:54, Josh Estelle notifications@github.com wrote:

Ah you're right.

The bug is smaller than I thought. The only problem looks like when you give the attacker only 1 army at the start, it doesn't do sensible things ;-) But I suppose that's an edge case that should just be considered bad input.

Josh

On Mon, Oct 26, 2020 at 11:48 AM Grega Stritar notifications@github.com wrote:

Hi, thanks for the email!

Are you sure?

Start Attacker Defender Winner End Status

1 2 v 1 1 1 Def. wins 1 1 v 1 Def. survives

12 3 v 2 3,3 5,3 Def. wins 2 1 v 2 Def. survives

Best, Grega

On 26 Oct 2020, at 19:41, Josh Estelle notifications@github.com wrote:

Very nice simulator! Very fast. Much faster than the one at riskodds.com that I had used before.

However, I noticed your simulator doesn't deal with small numbers of armies correctly. e.g., the attacker needs at least 2 armies just to attack. And in that case, they can only roll 1 die. Similarly, when the defender is down to 1 army, they only should roll one die.

Your simulator always rolls 3 dice for the attacker and 2 for the defender.

I've been playing online risk for over a decade over here: https://sillysoft.net/lux/ https://sillysoft.net/lux/ Nice implementation, fun community.

I was looking for a dice odds calculator to settle some arguments ;-)

If I get around to it, I'll fix this bug and send you a pull request :D

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/gstritar/DiceRoll/issues/1>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5IT6X6ISNFRAOWWSBG5QLSMW7GZANCNFSM4S7YRBOQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gstritar/DiceRoll/issues/1#issuecomment-716752171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX762IG24CIDRMVN6TST4LSMXABDANCNFSM4S7YRBOQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gstritar/DiceRoll/issues/1#issuecomment-716755193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5IT6XRMJH5GNGUA2ZWXSTSMXAX3ANCNFSM4S7YRBOQ.

[jestelle]

I know! That's always really fascinated me about this game. Particularly in online risk you can definitely end up with long games with 10k+ armies.

It'd be a nice feature request for your simulator to accept a parameter to simulate more total fights.

That would make it slower, but it'd be helpful for getting accurate probabilities for some of the bigger fights 800vs800 for example. Even thought I just clicked it 20 or so times and the defender never won once! =P

On Mon, Oct 26, 2020 at 12:00 PM Grega Stritar notifications@github.com wrote:

It is interesting, how the defender has the advantage on fighting e.g. 8:8.

But in a fight of 80:80, the attacker has a huge advantage. While in a 800:800 the defender does not even have the chance.

Best, Grega

On 26 Oct 2020, at 19:54, Josh Estelle notifications@github.com wrote:

Ah you're right.

The bug is smaller than I thought. The only problem looks like when you give the attacker only 1 army at the start, it doesn't do sensible things ;-) But I suppose that's an edge case that should just be considered bad input.

Josh

On Mon, Oct 26, 2020 at 11:48 AM Grega Stritar <notifications@github.com

wrote:

Hi, thanks for the email!

Are you sure?

Start Attacker Defender Winner End Status

1 2 v 1 1 1 Def. wins 1 1 v 1 Def. survives

12 3 v 2 3,3 5,3 Def. wins 2 1 v 2 Def. survives

Best, Grega

On 26 Oct 2020, at 19:41, Josh Estelle notifications@github.com wrote:

Very nice simulator! Very fast. Much faster than the one at riskodds.com that I had used before.

However, I noticed your simulator doesn't deal with small numbers of armies correctly. e.g., the attacker needs at least 2 armies just to attack. And in that case, they can only roll 1 die. Similarly, when the defender is down to 1 army, they only should roll one die.

Your simulator always rolls 3 dice for the attacker and 2 for the defender.

I've been playing online risk for over a decade over here: https://sillysoft.net/lux/ https://sillysoft.net/lux/ Nice implementation, fun community.

I was looking for a dice odds calculator to settle some arguments ;-)

If I get around to it, I'll fix this bug and send you a pull request :D

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/gstritar/DiceRoll/issues/1>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5IT6X6ISNFRAOWWSBG5QLSMW7GZANCNFSM4S7YRBOQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/gstritar/DiceRoll/issues/1#issuecomment-716752171 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAX762IG24CIDRMVN6TST4LSMXABDANCNFSM4S7YRBOQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/gstritar/DiceRoll/issues/1#issuecomment-716755193>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5IT6XRMJH5GNGUA2ZWXSTSMXAX3ANCNFSM4S7YRBOQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gstritar/DiceRoll/issues/1#issuecomment-716758138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX762O23LQHYG4KGPAND4DSMXBMZANCNFSM4S7YRBOQ .