search

gstroup / apimocker

node.js module to run a simple http server for mock service responses.
MIT License
280 stars 81 forks source link

Replace JSONPath dependency with jsonpath #98

Closed twalker closed 5 years ago

twalker commented 5 years ago

Replace the JSONPath dependency with jsonpath.

According to the note from JSONPath, JSONPath suffers from "npm problems in dealing with upper-case packages." I was experiencing npm install issues with JSONPath as reported in issue #97

The 'jsonpath' dependency is another module that implements the same JSONPath syntax, but without npm problems.

To verify

  1. npm install
  2. npm test.

Expected results: Unit tests should pass.

twalker commented 5 years ago

@gstroup , Sorry to nag, but do you have any concerns with merging this PR?

gstroup commented 5 years ago

Thanks for the reminder. It looks good. I'll try to merge it in today. Sorry for the delay! Would you like to be a collaborator, and help maintain this project in the future??

twalker commented 5 years ago

I'd be happy to be a contributor. I don't have as much time as I'd like to offer, but I'll certainly chip and make myself useful. Would you be open to freshening up the syntax to ES6 and targeting newer versions of node (e.g. 8-10)?

My team makes heavy use of apimocker and it has served us well. Thank you for the project.