search

gsuez / master-bootstrap-3

Joomla 3.x Template with Bootstrap 3
https://www.masterbootstrap.com/
142 stars 90 forks source link

Update link for fonts.gstatic.com to https #31

Closed Twincarb closed 7 years ago

Twincarb commented 8 years ago

Fix for when using the template in a pure https mode. fix for #30

gsuez commented 8 years ago

thanks! I can`t merge, because can cause problems for users who use http - most cases ;)

Regards

Twincarb commented 8 years ago

I am curious under what circumstances would it cause issues, it has no reliance on the webserver that is providing the website to provide a secure connection, the request is executed by the end user browser. As far as I am aware all the major browsers provide https support.

Twincarb commented 8 years ago

@gsuez I have adjusted the request so it's not hardcoded to http or https please review.

phproberto commented 8 years ago

:+1: this will require that we recompile sass files to get latest css files. I tried to generate new css files but apparently a lot of things are changed because sass + css files are not synchronised. But that's not related to this pull request.