gsurma / atari

AI research environment for the Atari 2600 games 🤖.
https://gsurma.github.io
MIT License
253 stars 81 forks source link

The reward is not clip in the codes #14

Open xqlin98 opened 2 years ago

xqlin98 commented 2 years ago

if clip: np.sign(reward) this operation can not change the value of reward, and it should be if clip: reward = np.sign(reward)

Maybe it's the problem of the NumPy version. In my numpy environment, sign didn't support in-place update.