search

gsyndromes / pe

0 stars 0 forks source link

coupon with the same name, same savings same dates can be added #4

Open gsyndromes opened 4 years ago

gsyndromes commented 4 years ago

image.png

nus-pe-bot commented 4 years ago

Team's Response

It is not the same, as "F", "f", and "G", "g" are different characters.

This is the same behaviour found on AddressBook where names are case-sensitive, such that upper-case and lower-case versions of the same alphabetical character are not considered the "same"

Severity has been downgraded as it is a mere cosmetic flaw with upper-case and lower-case spellings

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It is absurd to compare your implementation with AddressBook one as your implementation consists the usage of coupons. Coupon names usually have fixed name (e.g. a Company's name, or a specific type of event voucher) that does necessitate it each coupon is unique. It is a bug as Macdonalds would not release a Macdonald's coupon and a macdonalds coupon.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: This bug warrants a higher severity than Very Low. It is not a cosmetic flaw, what if the user first types in a GrabFood coupon, and the next day the user forgets that he/she has entered the grabfood coupon and entered it this time, as a Grabfood coupon. Now the user will mistakenly think that he/she has 2 grabfood coupons. This is undesirable by a user.