search

gt-cs2110 / cs2110docker

A Docker image containing Ubuntu 22.04 running the tools necessary for Georgia Tech's CS 2110.
2 stars 2 forks source link

cs2110docker.sh -it fails on some Windows systems #18

Closed sameer-s closed 2 years ago

sameer-s commented 2 years ago

the input device is not a TTY. If you are using mintty, try prefixing the command with 'winpty'

An easy workaround is adding winpty to that command in cs2110docker.sh, but that's nontrivial to students / they don't know to do it.

I believe the default option when installing Git Bash now is to use mintty so we will be seeing this more and more.

kanwren commented 2 years ago

Does winpty work here? I've had issues in the past. Also, it wouldn't be too hard to add a check in the script for this, but I'd like to be sure there's no better way first.

sameer-s commented 2 years ago

winpty seems to work as far as I can tell, so adding a check was pretty much my plan.

kanwren commented 2 years ago

Do you want me to take this, then? Should we just add a check for if winpty exists and attempt to run through that?

sameer-s commented 2 years ago

I totally missed this, but I think that would work.

I think there's some cases where winpty exists, but isn't needed, but since I really haven't had any issues with it (and this is after most of a semester of recommending students use it) I'm gonna assume that's probably not a problem.