search

gt-cs2110 / cs2110docker

A Docker image containing Ubuntu 22.04 running the tools necessary for Georgia Tech's CS 2110.
2 stars 2 forks source link

`pwd -W` occasionally does not work on Windows #4

Closed kanwren closed 3 years ago

kanwren commented 3 years ago

Currently in cs2110docker.sh, we use pwd -W on Windows and pwd everywhere else. I encountered a case of a student using Docker Desktop, running the cs2110docker.sh script from within Git Bash, where Docker did not like the Windows paths generated by pwd -W and crashed during the docker run. Not sure how to reproduce.

Note that this crash is more desirable and detectable than what would happen before, where Docker would bind to a new empty folder named something like C;tmp/.

It would be nice if we could more intelligently detect which path format Docker will accept, or make it easier to switch than editing the script. At the very least, this could be documented.

kanwren commented 3 years ago

See 551de1a

kanwren commented 3 years ago

Closing as we haven't had any issues since 551de1a, but it's good for future reference to note that Docker for Windows expects Windows-style paths, and everything else (including Docker Toolbox) expects Unix-style paths.