search

gt-health / GT-FHIR

Georgia Tech FHIR Server Web Page
36 stars 28 forks source link

Mergenewresources #91

Closed MarkieMark closed 8 years ago

MarkieMark commented 8 years ago

Hi Myung / Jaya / Ismael,

The pull request should contain all the modifications we made to the code base to add the most in-demand new FHIR Resource types;

We added proper build instructions too, as well as adjusting the maven directives so that it builds automatically from a top-level "mvn clean install" command

As you'll notice the code changes are quite incomplete; mainly although the new Resource types would appear as Resources on the server, most of the fields of the new Resources aren't fully coded. As Professor Braunstein has said we'll be accessing the MiHIN FHIR server for our projects this semester, the chances are we won't necessarily write all the details of that code for the time being; therefore it seems worthwhile making a timely pull request so that the changes are mergeable into the main codebase while they're fresh

The modified server code [without the more recent changes to master of https://github.com/i3l/GT-FHIR] is working at http://104.197.124.155/gt-fhir-webapp/ for the time being, although that's a time-limited free google cloud instance

Looking forward to hearing from you

Best regards

Mark

jarao commented 8 years ago

Mark,

So what you're saying is you would like us to do a pull and integrate these changes with our existing local repositories?

Thanks, Jaya

On Mar 18, 2016, at 9:48 AM, Mark Benjamin notifications@github.com wrote:

Hi Jaya / Ismael,

The pull request should contain all the modifications we made to the code base to add the most in-demand new FHIR Resource types;

We added proper build instructions too, as well as adjusting the maven directives so that it builds automatically from a top-level "mvn clean install" command

As you'll notice the code changes are quite incomplete; mainly although the new Resource types would appear as Resources on the server, most of the fields of the new Resources aren't fully coded. As Professor Braunstein has said we'll be accessing the MiHIN FHIR server for our projects this semester, the chances are we won't necessarily write all the details of that code for the time being; therefore it seems worthwhile making a timely pull request so that the changes are mergeable into the main codebase while they're fresh

The modified server code [without the more recent changes to master of https://github.com/i3l/GT-FHIR] is working at http://104.197.124.155/gt-fhir-webapp/ for the time being, although that's a time-limited free google cloud instance

Looking forward to hearing from you

Best regards

Mark

You can view, comment on, or merge this pull request online at:

https://github.com/i3l/GT-FHIR/pull/91

Commit Summary

add build instructions to readme Improve presentation of build instructions improve build / deploy instructions make build/deploy instructions more specific make build/deploy instructions more specific adjust some typos adjust some typos add mvn build instruction for base gtFHIR directory add mvn build instruction for base gtFHIR directory create proper maven build order hierarchy Update readme to describe automatic maven build automatically mvn clean install from IntelliJ run config Merge branch 'newresources' of https://github.gatech.edu/cdchealthyweight/gtFHIR into newresources update readme to describe IntelliJ automatic build/deploy correct cd typo consistent tomcat directory description consistent tomcat directory description merge build/deploy changes to master template for adding new Resource; upgrade/add Provider basic questionnaire code added add bean reference to produce webpage listing for questionnaire implement Questionnaire Resource type Entity content bare methods add persistence table description to QuestionsAnswers add persistence reference to QuestionsAnswers add Appointment Resource type basic code add basic code for Immunization Resource type add basic code for ProcedureRequest Resource type add basic code for Flag Resource type add basic code for ImmunizationRecommendation Resource type add basic code for RelatedPerson Resource type resolve Inoculation/Innoculation adjust automatic authorship strings rename QuestionsAnswers to Questions add basic code for QuestionnaireResponse Resource type add basic code for Communication Resource type add basic code for CommunicationRequest Resource type add basic code for ReferralRequest Resource type add basic code for RiskAssessment Resource type add basic code for AppointmentResponse Resource type add some field handling to ReferenceRequest(ReferralRequest) add identifier, date columns to Reference(Referral)Request add more fields to Referral(Reference)Request Merge branch 'master' of https://github.com/MarkieMark/GT-FHIR Merge branch 'newresources' into mergenewresources File Changes

A .idea/runConfigurations/fhir_webapp_local.xml (76) M README.md (51) M gt-fhir-entities/pom.xml (2) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Alert.java (81) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Engagement.java (78) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/EngagementResponse.java (80) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Individual.java (83) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Inoculation.java (78) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/InoculationRecommendation.java (83) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Message.java (82)
A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/MessageRequest.java (83) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/ProcRequest.java (82) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Prognosis.java (83) M gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Provider.java (10) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Questions.java (78) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/QuestionsAnswers.java (82) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/ReferenceRequest.java (181) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/RelatedIndividual.java (83) M gt-fhir-jpabase/pom.xml (15) M gt-fhir-overlay/pom.xml (12) M gt-fhir-webapp/pom.xml (10) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/AppointmentFhirResourceDao.java (23) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/AppointmentResponseFhirResourceDao.java (23) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/CommunicationFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/CommunicationRequestFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/FlagFhirResourceDao.java (20) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/ImmunizationFhirResourceDao.java (22) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/ImmunizationRecommendationFhirResourceDao.java (22) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/PersonFhirResourceDao.java (23) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/PractitionerFhirResourceDao.java (18) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/ProcedureRequestFhirResourceDao.java (22) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/QuestionnaireFhirResourceDao.java (18) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/QuestionnaireResponseFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/ReferralRequestFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/RelatedPersonFhirResourceDao.java (22) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/RiskAssessmentFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/AppointmentResourceProvider.java (146) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/AppointmentResponseResourceProvider.java (141) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/CommunicationRequestResourceProvider.java (171) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/CommunicationResourceProvider.java (166) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/FlagResourceProvider.java (135) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/ImmunizationRecommendationResourceProvider.java (154) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/ImmunizationResourceProvider.java (186) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/PersonResourceProvider.java (201) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/PractitionerResourceProvider.java (142) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/ProcedureRequestResourceProvider.java (140) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/QuestionnaireResourceProvider.java (141) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/QuestionnaireResponseResourceProvider.java (146) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/ReferralRequestResourceProvider.java (146) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/RelatedPersonResourceProvider.java (185) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/RiskAssessmentResourceProvider.java (146) M gt-fhir-webapp/src/main/resources/META-INF/persistence.xml (14) M gt-fhir-webapp/src/main/webapp/WEB-INF/fhir-server-resourceproviders-dstu2.xml (201) M gt-fhir-webapp/src/main/webapp/WEB-INF/fhir-webapp-config.xml (6) M pom.xml (594) Patch Links:

https://github.com/i3l/GT-FHIR/pull/91.patch https://github.com/i3l/GT-FHIR/pull/91.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

MarkieMark commented 8 years ago

Hi Jaya,

As long as you're happy to, then I'd say it's worthwhile. The current state of mergenewresources includes the most recent changes to https://github.com/i3l/GT-FHIR master, so it should all be very workable

Best regards

Mark

myungchoi commented 8 years ago

Jaya,

Before integrating the pull request(s), please make sure you let me and Ismael know. We all need to know what has been changed and what impact it would have.

All, By the way, we are using OMOP database, which may not have all the necessary tables to hold the new resources we are trying to add. In this case, we may need to create a new table to hold the dataset. Please do this if you had to create a new table, use put “f_” front of all new tables.

And, please note that the Allergy related table will be deleted in our next upgrade. We are trying to find out a way to put the allergies in OMOP format. Then, the allergy related tables will be deleted.

Thank you all for working on the FHIR server.

Thanks, Myung

On Mar 18, 2016, at 10:43 AM, Jaya Rao notifications@github.com wrote:

Mark,

So what you're saying is you would like us to do a pull and integrate these changes with our existing local repositories?

Thanks, Jaya

On Mar 18, 2016, at 9:48 AM, Mark Benjamin notifications@github.com wrote:

Hi Jaya / Ismael,

The pull request should contain all the modifications we made to the code base to add the most in-demand new FHIR Resource types;

We added proper build instructions too, as well as adjusting the maven directives so that it builds automatically from a top-level "mvn clean install" command

As you'll notice the code changes are quite incomplete; mainly although the new Resource types would appear as Resources on the server, most of the fields of the new Resources aren't fully coded. As Professor Braunstein has said we'll be accessing the MiHIN FHIR server for our projects this semester, the chances are we won't necessarily write all the details of that code for the time being; therefore it seems worthwhile making a timely pull request so that the changes are mergeable into the main codebase while they're fresh

The modified server code [without the more recent changes to master of https://github.com/i3l/GT-FHIR] is working at http://104.197.124.155/gt-fhir-webapp/ for the time being, although that's a time-limited free google cloud instance

Looking forward to hearing from you

Best regards

Mark

You can view, comment on, or merge this pull request online at:

https://github.com/i3l/GT-FHIR/pull/91

Commit Summary

add build instructions to readme Improve presentation of build instructions improve build / deploy instructions make build/deploy instructions more specific make build/deploy instructions more specific adjust some typos adjust some typos add mvn build instruction for base gtFHIR directory add mvn build instruction for base gtFHIR directory create proper maven build order hierarchy Update readme to describe automatic maven build automatically mvn clean install from IntelliJ run config Merge branch 'newresources' of https://github.gatech.edu/cdchealthyweight/gtFHIR into newresources update readme to describe IntelliJ automatic build/deploy correct cd typo consistent tomcat directory description consistent tomcat directory description merge build/deploy changes to master template for adding new Resource; upgrade/add Provider basic questionnaire code added add bean reference to produce webpage listing for questionnaire implement Questionnaire Resource type Entity content bare methods add persistence table description to QuestionsAnswers add persistence reference to QuestionsAnswers add Appointment Resource type basic code add basic code for Immunization Resource type add basic code for ProcedureRequest Resource type add basic code for Flag Resource type add basic code for ImmunizationRecommendation Resource type add basic code for RelatedPerson Resource type resolve Inoculation/Innoculation adjust automatic authorship strings rename QuestionsAnswers to Questions add basic code for QuestionnaireResponse Resource type add basic code for Communication Resource type add basic code for CommunicationRequest Resource type add basic code for ReferralRequest Resource type add basic code for RiskAssessment Resource type add basic code for AppointmentResponse Resource type add some field handling to ReferenceRequest(ReferralRequest) add identifier, date columns to Reference(Referral)Request add more fields to Referral(Reference)Request Merge branch 'master' of https://github.com/MarkieMark/GT-FHIR Merge branch 'newresources' into mergenewresources File Changes

A .idea/runConfigurations/fhir_webapp_local.xml (76) M README.md (51) M gt-fhir-entities/pom.xml (2) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Alert.java (81) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Engagement.java (78) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/EngagementResponse.java (80) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Individual.java (83) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Inoculation.java (78) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/InoculationRecommendation.java (83) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Message.java (82) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/MessageRequest.java (83) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/ProcRequest.java (82) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Prognosis.java (83) M gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Provider.java (10) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/Questions.java (78) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/QuestionsAnswers.java (82) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/ReferenceRequest.java (181) A gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/RelatedIndividual.java (83) M gt-fhir-jpabase/pom.xml (15) M gt-fhir-overlay/pom.xml (12) M gt-fhir-webapp/pom.xml (10) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/AppointmentFhirResourceDao.java (23) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/AppointmentResponseFhirResourceDao.java (23) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/CommunicationFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/CommunicationRequestFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/FlagFhirResourceDao.java (20) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/ImmunizationFhirResourceDao.java (22) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/ImmunizationRecommendationFhirResourceDao.java (22) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/PersonFhirResourceDao.java (23) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/PractitionerFhirResourceDao.java (18) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/ProcedureRequestFhirResourceDao.java (22) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/QuestionnaireFhirResourceDao.java (18) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/QuestionnaireResponseFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/ReferralRequestFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/RelatedPersonFhirResourceDao.java (22) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/dao/RiskAssessmentFhirResourceDao.java (21) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/AppointmentResourceProvider.java (146) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/AppointmentResponseResourceProvider.java (141) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/CommunicationRequestResourceProvider.java (171) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/CommunicationResourceProvider.java (166) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/FlagResourceProvider.java (135) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/ImmunizationRecommendationResourceProvider.java (154) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/ImmunizationResourceProvider.java (186) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/PersonResourceProvider.java (201) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/PractitionerResourceProvider.java (142) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/ProcedureRequestResourceProvider.java (140) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/QuestionnaireResourceProvider.java (141) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/QuestionnaireResponseResourceProvider.java (146) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/ReferralRequestResourceProvider.java (146) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/RelatedPersonResourceProvider.java (185) A gt-fhir-webapp/src/main/java/edu/gatech/i3l/fhir/jpa/providers/RiskAssessmentResourceProvider.java (146) M gt-fhir-webapp/src/main/resources/META-INF/persistence.xml (14) M gt-fhir-webapp/src/main/webapp/WEB-INF/fhir-server-resourceproviders-dstu2.xml (201) M gt-fhir-webapp/src/main/webapp/WEB-INF/fhir-webapp-config.xml (6) M pom.xml (594) Patch Links:

https://github.com/i3l/GT-FHIR/pull/91.patch https://github.com/i3l/GT-FHIR/pull/91.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/i3l/GT-FHIR/pull/91#issuecomment-198391372

MarkieMark commented 8 years ago

Hi Myung,

We were working with an empty [no data] database during development, we found that the app created the necessary tables when launched; although with no data, it was trivial to drop tables before launching a revised version of the app. There was no need to create tables manually. For the production server, I think an sqldump of the current data, without the data definition commands, would work, to recreate the current data when the database upgrades itself; I guess you do that [retrieving the data from an sqldump] already whenever you refresh the content of the database to its basis state? When you say OMOP database, I think that is the MySQL fhir_omop database that we found coded for

The changes to the code itself should all be visible at the most recent commit in that list, https://github.com/i3l/GT-FHIR/pull/91/commits/891e996becfe6032ba41afea487d8d93ec9ea054, basically we just added FHIR Resource types, without coding all the fields for those Resource types; though it would of course be optimal to code all the fields, there's a substantial chunk of work there already that is worth adding to the codebase even though there's more to do to perfect even the few Resource types we've added.

Then the very limited structural changes should be visible at https://github.com/i3l/GT-FHIR/pull/91/files; the build instructions are included as additions to the readme; while the maven changes were in the event virtually entirely simply to add suitable parent parameters so that a top-level clean install would invoke the submodules in the right order

Best regards

Mark

myungchoi commented 8 years ago

Mark,

Your pull request will be integrated. We need Isamel to take a look at the changes. I want to have “Go” from ismael as he is also working on the server code. He is in Brazil now. So, we need to give him a few days until he catch up with emails.

Thank you very much.

Jaya, please also look at the requests and see if they all look OK. I will also do that. If you have “Go” from Ismael and me, you can go ahead and integrate them.

Thanks. Myung

On Mar 18, 2016, at 11:04 AM, Mark Benjamin notifications@github.com wrote:

Hi Jaya,

As long as you're happy to, then I'd say it's worthwhile. The current state of mergenewresources includes the most recent changes to https://github.com/i3l/GT-FHIR https://github.com/i3l/GT-FHIR master, so it should all be very workable

Best regards

Mark

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/i3l/GT-FHIR/pull/91#issuecomment-198400154

MarkieMark commented 8 years ago

Hi Myung,

Thanks very much :-)

I should try to describe, in view of what you say re the database structure, how we added new FHIR Resource types, as I could adjust the naming of classes / tables to create a better distinction between OMOP & Non-OMOP Entities in edu.gatech.i3l.fhir.dstu2.entities at gt-fhir-entities/src/main/java/edu/gatech/i3l/fhir/dstu2/entities/;

Basically we accorded with the current structure of an Entity being the primary class, mapping on the one hand to a database table, then mapping to a FHIR Resource with the getRelatedResource() / constructEntityFromResource() methods; as the schema of the OMOP Entities is that generally an OMOP Entity name is not identical to the FHIR Resource name, we just coded similar-yet-relatively-obvious Entity names as the Entity class names; Alert/Flag, Engagement/Appointment, EngagementResponse/AppointmentResponse, Individual/Person, Inoculation/Immunization, InoculationRecommendation/ImmunizationRecommendation, Message/Communication, MessageRequest/CommunicationRequest, ProcRequest/ProcedureRequest, Prognosis/RiskAssessment, Questions/Questionnaire, QuestionsAnswers/QuestionnaireResponse, ReferenceRequest/ReferralRequest, RelatedIndividual/RelatedPerson;

Thinking of what you said, that the f_ prefix would be helpful to distinguish OMOP tables from non-OMOP tables, my current thinking is that unless you say not to, then I'll be refactoring those class names before the merge, so that Alert is renamed as FHIRFlag, Engagement is renamed as FHIRAppointment, EngagementResponse is renamed as FHIRAppointmentResponse, Individual is renamed as FHIRPerson, Inoculation is renamed as FHIRImmunization, InoculationRecommendation is renamed as FHIRImmunizationRecommendation, Message is renamed as FHIRCommunication, MessageRequest is renamed as FHIRCommunicationRequest, ProcRequest is renamed as FHIRProcedureRequest, Prognosis is renamed as FHIRRiskAssessment, Questions is renamed as FHIRQuestionnaire, QuestionsAnswers is renamed as FHIRQuestionnaireResponse, ReferenceRequest is renamed as FHIRReferralRequest, RelatedIndividual is renamed as FHIRRelatedPerson, with the tables correspondingly renamed as f_flag, f_appointment, etcetera

Best regards

Mark

ismael-sarmento-jr commented 8 years ago

Good afternoon. As I am working on adjusting hapi-fihr (JPA project) to our needs, so we won´t be behind their new features for data access layer, you guys can commit to tech-on-fhir repo with no problems.

On Fri, Mar 18, 2016 at 2:13 PM, Myung Choi notifications@github.com wrote:

Mark,

Your pull request will be integrated. We need Isamel to take a look at the changes. I want to have “Go” from ismael as he is also working on the server code. He is in Brazil now. So, we need to give him a few days until he catch up with emails.

Thank you very much.

Jaya, please also look at the requests and see if they all look OK. I will also do that. If you have “Go” from Ismael and me, you can go ahead and integrate them.

Thanks. Myung

On Mar 18, 2016, at 11:04 AM, Mark Benjamin notifications@github.com wrote:

Hi Jaya,

As long as you're happy to, then I'd say it's worthwhile. The current state of mergenewresources includes the most recent changes to https://github.com/i3l/GT-FHIR https://github.com/i3l/GT-FHIR master, so it should all be very workable

Best regards

Mark

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub < https://github.com/i3l/GT-FHIR/pull/91#issuecomment-198400154>

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/i3l/GT-FHIR/pull/91#issuecomment-198458485

i3lgatech commented 8 years ago

DSTU version for this is changed. And, this issue has been resolved when upgrading to new DSTU.