gt-scheduler / website

Scheduling application designed to mitigate some of the pain-points present throughout Georgia Tech's registration process.
https://gt-scheduler.org
GNU Affero General Public License v3.0
87 stars 22 forks source link

Invitation modal #287

Closed joannacheng21 closed 3 months ago

joannacheng21 commented 4 months ago

Summary

Resolves #281

Checklist

How to Test

Change cloud function base url to test

Notes:

  1. When I try to send email invite, I'm getting the error Error: connect ECONNREFUSED 127.0.0.1:465 from nodemailer, I don't think this is my code's problem? or maybe it is
  2. Had to make couple changes to firebase functions, should I make pr to firebase repo?
  3. Question: "Modify the logic for checking if the invitee has already accepted an invite from the sender." what are we doing if the invitee has accepted invites for some but not all selected schedules?
  4. How are we setting validFor field for links that never expire? put it as 1000 days for now
github-actions[bot] commented 4 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://gt-scheduler.github.io/website/pr-preview/pr-287/ on branch gh-pages at 2024-03-23 07:37 UTC

winniezhangg commented 4 months ago

Hi Joanna! A couple of comments on the design for the invite modal Reference to what the Figma Design looks like:

Screen Shot 2024-02-25 at 2 43 33 PM
  1. Apologies if this was not specified enough on the Figma and ticket, but the scrollable div should be: Screen Shot 2024-02-25 at 6 49 26 PM

    instead of how it is right now with each section being scrollable

this is how it should look:

Screen Shot 2024-02-25 at 6 50 24 PM
  1. Please left align the schedule checkboxes with the left side of the email input

    Screen Shot 2024-02-25 at 6 51 12 PM
  2. Same with the copy link button and link expires button, align them with the inner edge:

    Screen Shot 2024-02-25 at 6 53 01 PM

Good work so far! Let me know if I can help clarify anything! Ping me if you have updates and need feedback!