search

gta-chaos-mod / ChaosModV

Chaos Mod for Grand Theft Auto V
https://gta5-mods.com/scripts/chaos-mod-v-beta
GNU General Public License v3.0
251 stars 90 forks source link

Added Real First Person effect #3564

Closed Chanka0 closed 9 months ago

Chanka0 commented 10 months ago

Forced First Person but EVEN MORE painful immersive. Vanilla first person prioritizes the player's mouse movements and moves the camera accordingly, this effect does the opposite. While active the player's view is changed to a camera that is driven by the player character's head movements. Aiming has been adjusted for usability.

If you want an example of it in use look at footage from the GTA V first person cutscenes mod. The main difference between the two is camera roll being enabled which can be adjusted by replacing boneRot.y with 0 in line 78. Also the effect is not currently enabled in cutscenes but that can be easily remedied.

Edits: Grammar, name change

Chanka0 commented 10 months ago

Pushed commit with suggested changes

Chanka0 commented 10 months ago

Changes have been made and tested. Also it's worth mentioning that there are camera effects in the player category, such as GTA2, LagCamera, and ZoomZoomCam.

Regynate commented 10 months ago

there are camera effects in the player category, such as GTA2, LagCamera, and ZoomZoomCam.

Yeah, they need to be moved to the Screen category

pongo1231 commented 10 months ago

Haven't been able to test it yet but if it's basically a more extreme version of the First Person effect we could just straight up replace it with this version. Unless there are some caveats with it.

Also I'd be for enabling cutscene support, given it doesn't break anything (e.g. the camera isn't in a meddled state if the effect ends during a cutscene).

Chanka0 commented 10 months ago

The only caveat of this effect is potential motion sickness which is already a thing thanks to Spinning Camera. Aiming was intentionally made smoother for when the player was driving/running/etc.

Also cutscene support isn't an issue. There's a specific function to enable/disable cutscene cameras taking priority so as soon as the effect ends the cutscene camera can take over instantly. I wasn't about including it because it's like watching a movie edited together from the director assistants camera. You see all the inconsistencies and spot lighting change between cuts.

On Wed, Sep 6, 2023, 3:42 PM pongo1231 @.***> wrote:

Haven't been able to test it yet but if it's basically a more extreme version of the First Person effect we could just straight up replace it with this version. Unless there are some caveats with it.

Also I'd be for enabling cutscene support, given it doesn't break anything (e.g. the camera isn't in a meddled state if the effect ends during a cutscene).

— Reply to this email directly, view it on GitHub https://github.com/gta-chaos-mod/ChaosModV/pull/3564#issuecomment-1709168442, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEJOROIOHZGZWYC2WJVDKGTXZDU55ANCNFSM6AAAAAA4LGIAR4 . You are receiving this because you authored the thread.Message ID: @.***>

pongo1231 commented 10 months ago

The only caveat of this effect is potential motion sickness which is already a thing thanks to Spinning Camera. Aiming was intentionally made smoother for when the player was driving/running/etc.

In that case I think we should go with it and replace the existing First Person effect with this version rather than having 2 same-ish effects with one just being a more extreme version of the other.

Also cutscene support isn't an issue. There's a specific function to enable/disable cutscene cameras taking priority so as soon as the effect ends the cutscene camera can take over instantly. I wasn't about including it because it's like watching a movie edited together from the director assistants camera. You see all the inconsistencies and spot lighting change between cuts.

Seems perfectly fine to me. That'd just add to the chaos and breaking the game in weird ways is part of the fun of the mod.

Chanka0 commented 10 months ago

Alright, I'll add in the cutscene support soon. btw if the first person effect is being replaced, should there be something done to signify that it's new/changed?

Edit: Silly name came to mind, rename First Person to Real First Person. Should indicate that it's a new effect.

pongo1231 commented 10 months ago

No other action is strictly necessary. Renaming the effect to "Real First Person" seems like a neat idea though and would indeed make players aware something has changed with the effect.

MoneyWasted commented 10 months ago

for legal reasons changing the name of the effect would be a good move, how about “Action Mount”

Chanka0 commented 10 months ago

If this is replacing First Person I think Real First Person works best. It reflects what the effect is while showing that it is new and different from what it's replacing.

Unless anyone disagrees with it I'll change the name to that and remove the old First Person

On Sat, Sep 9, 2023, 1:27 PM Tommy @.***> wrote:

for legal reasons changing the name of the effect would be a good move, how about “Action Mount”

— Reply to this email directly, view it on GitHub https://github.com/gta-chaos-mod/ChaosModV/pull/3564#issuecomment-1712584293, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEJOROPUM2EDJ2JPEX6SUTTXZS7LJANCNFSM6AAAAAA4LGIAR4 . You are receiving this because you authored the thread.Message ID: @.***>

pongo1231 commented 10 months ago

No disagreement here 👍