search

gta-chaos-mod / Trilogy-ASI-Script

The ASI script for the GTA Trilogy (SA only for now, 3 and VC may follow later on)
GNU General Public License v3.0
141 stars 21 forks source link

New effect: `Randomize player stats` #214

Closed gromchek closed 1 year ago

gromchek commented 1 year ago

I haven't checked all the stats (e.g. girlfriend relationship level, lung capacity, respect), but these work well. The sex appeal stat seems work more complicated than just change value. I noticed that the change stats after start new game but before notify tooltip ("Use WASD to move Carl" something like that) maybe work inncorectly.

Lordmau5 commented 1 year ago

Oh dear god why does this have to be 22 separate effects, please don't.

When I read that issue / effect suggestion I thought of a list of stats that make sense to be randomized (as you did as well in your implementation) - but definitely not all of this crazyness haha

I'd recommend doing just 1 One-Time effect that randomizes them once. Maybe also a timed effect that reverts back to what they were before (Shouldn't matter too much if they suddenly get a huge bump from e.g. Flight or Driving School)

gromchek commented 1 year ago

Ok. Updated. Anyway, in the future we can easily split stats into different categories

Lordmau5 commented 1 year ago

Requested a few style changes. Could it be that whatever you're using for editing isn't properly taking the .clang-format file into account?

When I saved your previous 2 effects in VSCode they were reformatted a bit... Might also be extra settings in my VSCode that I'm not aware of

gromchek commented 1 year ago

Could it be that whatever you're using for editing isn't properly taking the .clang-format file into account?

I use Visual Studio (not VSCode) and clang-format doesn't seem to work properly every time.

I found it: I need to press Ctrl+K+D manually to format

Lordmau5 commented 1 year ago

I found it: I need to press Ctrl+K+D manually to format

Is that native in Visual Studio or did you have to install an extension? Maybe there's a "Format on Save" option somewhere, might be nice to have for this project (not trying to force you to use it globally haha)

gromchek commented 1 year ago

Is that native in Visual Studio or did you have to install an extension? Maybe there's a "Format on Save" option somewhere, might be nice to have for this project (not trying to force you to use it globally haha)

This helped me https://stackoverflow.com/a/66058774 Now it works

Jersukai commented 9 months ago

Not sure if this is the right place to report this but there's a bug with the timed effect. If you load a save when it's active you get the original stats back.