search

gta-chaos-mod / Trilogy-ASI-Script

The ASI script for the GTA Trilogy (SA only for now, 3 and VC may follow later on)
GNU General Public License v3.0
141 stars 21 forks source link

New effect: Spawn fire around player #228

Closed gromchek closed 1 year ago

gromchek commented 1 year ago

The effect generates fire around the player every few seconds. If a ped touches the fire, the ped ignites.

Lordmau5 commented 1 year ago

Looks good!

Also, why do you always force push a completely new file instead of committing only the changes? Makes it a bit hard to see the difference :D

gromchek commented 1 year ago

I have two projects: my fork and this repo. Because I started working on this mod long before my first PR. (I had problems with compilation). When I create a new effect, I just copy the file into the fork and then push it. Maybe sometimes github doesn't show the diff correctly I think. Or maybe it's only after the rebase.

Lordmau5 commented 1 year ago

It seems like you are force-pushing the changes instead of pushing them like normal... you shouldn't need to do a rebase for changing a single file though

If you work on a PR like this then you don't even need to get up-to-date with the main branch as long as there aren't any file conflicts (say you edit the GameUtil.cpp file and I have also edited it on the main repo)

gromchek commented 1 year ago

Okay. I got it.