search

gta-chaos-mod / Trilogy-ASI-Script

The ASI script for the GTA Trilogy (SA only for now, 3 and VC may follow later on)
GNU General Public License v3.0
139 stars 21 forks source link

New effect: WASD cheats activation #244

Closed gromchek closed 11 months ago

gromchek commented 1 year ago

Actually this effect doesn't activate one-time cheats like $250k+health+armor, a weapon pack, blow up all cars etc. Maybe if the future some one will implement it

Lordmau5 commented 1 year ago

Hmm I'm not sure how well the whole cheats system will end up working as a whole.

The base game cheats are being set every tick through the TimedAddressEffect from what I remember.

So while you could be setting them every game tick, reverting to the original cheats that were active at this time might break the game further down the line.

If I may suggest something: How about changing this effect into a "Fake Cheat Activation" kinda effect?

So it would still do the whole WASD check but it would only show that a cheat got activated. Not which one.

The only problem I see is that this would be more of a silly cosmetic effect in the end. If anything, I'd need to refactor how effects are being sent so this would be an "extra hidden effect" that get's sent randomly when another one happens, so it won't show to the player at all (or at least until one "cheat" got activated)

gromchek commented 1 year ago

We can create "weak" cheats (not powerful as regular cheats). Refill health + $10k, give some ammo, set all vehicles to 250 hp, spawm a cheap car, etc.

Lordmau5 commented 1 year ago

That might be better, yes.

I'd also suggest that you do a custom handler for the cheats such as not to mess with the internals of the game in that regard.

Would bring in compatibility with the Chaos Mod Complementaries feature of disabling cheat input, seeing as that is constantly clearing the cheat string here: https://github.com/gta-chaos-mod/ChaosModComplementaries/blob/main/src/gtasa/GameHandler.h#L287

Lordmau5 commented 1 year ago

Btw I want to mention I did not forget about all the PRs you did and I still very much appreciate that you put the time into them

I've just got way too much on my mind as of late and didn't find the time to update the Chaos Mod again due to other projects and IRL stuff as well...

I'll try my best to look at them again in August though (as I'm gonna be busy until then, too) 🙏

gromchek commented 1 year ago

I have some problems with building the project (even with a clear build after clone the repo). I'll check it later. I had to compile the project with x86 arch not x64. Solved