search

gta-reversed / gta-reversed-modern

Reimplementation of GTA:SA 1.0 US
522 stars 88 forks source link

Code stuck in an infinite loop in `I_NextKeyFrame` #685

Open Pirulax opened 5 months ago

Pirulax commented 5 months ago

Expected and current behavior

This loop: https://github.com/gta-reversed/gta-reversed-modern/blob/e975a511c1788880f6c8a548da9187e38bfb2131/source/game_sa/Animation/AnimBlendNode.h#L109 Gets kinda stuck, not even step bro can help... m_RemainingTime is negative, and for some reason it never becomes positive (As if all key-frames had 0 delta times) I had this issue before merging #655 too, so I don't think it causes it. I tried adding asserts to the anim loading code, but that didn't uncover anything.

Additional information

No response

Steps to reproduce

  1. Enter into the game
  2. ???
  3. Profit

Screenshots/Videos

No response

Pirulax commented 3 weeks ago

Possibly fixed by #715?