search

gta-reversed / gta-reversed-modern

Reimplementation of GTA:SA 1.0 US
559 stars 96 forks source link

fix #710 #762

Closed Keiichi86 closed 2 months ago

Keiichi86 commented 2 months ago

Fixes the issue mentioned in https://github.com/gta-reversed/gta-reversed-modern/issues/710

Pirulax commented 2 months ago

As far as I know the game actually indexes slots starting from 1, not 0. @yukani do you remember anything about this?

yukani commented 2 months ago

it's internally zero indexed but save files are one indexed. this func was zero indexed as well but it's unintuitive for ini config option to mismatch with save file index.

it seems the problem is SimulateGameLoad gets one based index passed. this should be enough:

-FrontEndMenuManager.SimulateGameLoad(false, slot);
+FrontEndMenuManager.SimulateGameLoad(false, slot - 1);
Keiichi86 commented 2 months ago

Agreed.

yukani commented 2 months ago

I'm looking forward to merge if you have tested this new version

Keiichi86 commented 2 months ago

I did test it before committing.

Pirulax commented 2 months ago

Thank you very much for your contribution!