search

gtache / scalajs-gradle

A Gradle plugin adding basic functions to support Scala.js
20 stars 14 forks source link

Support for newer versions of Scalajs #22

Open TodGilbertHarter opened 6 years ago

TodGilbertHarter commented 6 years ago

Scalajs has continued to march forward, and frankly I can't even get a lot of useful client-side code to compile anymore under 0.6.15 and earlier versions. I understand there is significant API differences in later versions of sbt that appear to be needed to support the newer 0.6.17+ of sjs.

Is someone interested in working on an update to add support for these? scalajs-gradle seems to be the only show in town in terms of gradle plugins, so it would be super awesome if we could accomplish this.

mpgirro commented 6 years ago

Would love to see a sjs 1.0.0 support too!

TodGilbertHarter commented 6 years ago

Hi, just to update on this. I WAS able to recompile the plugin to work with 0.6.21 and scala 2.12.4. I haven't attempted to create a version that works with 1.0.0-M2. I know there are some differences between that and the 0.6.x branch, just not sure of the details or if it rises to the level where it impacts the APIs that the gradle plugin uses. I could do a fork and a pull request, but it seems like there's little activity here. Note: I also included the one-line fix that is in the outstanding pull request for ModuleKind, which it turns out I needed to have access to. Anyway, its trivial to recompile, you really just need to change the version numbering in the build files. I would encourage trying 1.x and I'd consider helping out with that if it turned out to be non-trivial (but I am not exceptionally knowledgeable about gradle plugins, so not sure how much help I would be).