Add GND Identifier from plugin data to e21 and e74

[thomashaensli]

Hi Matteo,

can you add an additional identifier just above the ulan id in line 32

https://github.com/gtadigital/ProfileParser/blob/e04d62768e7eb9bb7a455d96476598ccf77ee31f/Profiles/Group/Group.xsl#L32

The additional identifier ist for GND and to be found in the custom section of the data

https://github.com/gtadigital/grp-datasource/blob/2b4dc9cfa42f0db0aab892181f89649d3f17206a/samples/e74_sample_20220428_th.xml#L951-L961

My take on where the conceptURI is to be found:

    <custom name="......"  type="custom:base.custom-data-type-gnd.gnd">
      ...
      <string name="conceptURI">https://d-nb.info/gnd/118676873</string>   
      ...
    </custom>

[thomashaensli]

Dear @matteoLorenzini I am pushing this issue from DONE to UNDERA REVIEW since it is not yet in production.

Also., I am not sure if the transformation with reference to the tag custom as currently implemented in the XSL is sufficient, since there might be multiple customdata fields in the export. May better to also refer to the type (see above).

Thanks for keeping that in mind.

[thomashaensli]

Hi @matteoLorenzini

please re-check the XSL transformation of GND identifier:

the current iteration selects for <xsl:variable name="gnd" select="pr:custom/pr:string[@name='conceptURI']" />

Where as the source xml can hold several different strings with key custom Example see https://github.com/gtadigital/grp-datasource/blob/152cf5c1803ee2831c44ac2cd4f3a1e2ac44df0a/samples/e21_sample_20220524_th.xml#L953-L973

I think you should also add type="custom:base.custom-data-type-gnd.gnd" to the selecting argument.