gtadigital / ProfileParser

Other
1 stars 2 forks source link

Fix format of AKL identifier after XSL tranformation#36 #80

Open thomashaensli opened 2 years ago

thomashaensli commented 2 years ago

Hi Matteo,

the format of the Foto.ch identifier after XSL transformation should read 30790

https://github.com/gtadigital/grp-datasource/blob/152cf5c1803ee2831c44ac2cd4f3a1e2ac44df0a/samples/e21_transformed.xml#L14

For both e21 and e74

matteoLorenzini commented 2 years ago

The comment points to FOTO.CH but the title of the issue refers to AKL. Do I need to modify FOTO.CH, AKL or both?

thomashaensli commented 2 years ago

Copy paste error, sorry

However, the issue relates both foto.ch and AKL:

matteoLorenzini commented 2 years ago

then please check also my comment here

thomashaensli commented 2 years ago

Hi @matteoLorenzini is just checked the output on https://github.com/gtadigital/grp-datasource/blob/main/samples/e21.rdf

In my view is really only a question on how the rdfs:label is defined for all similar cases.

For instance,

[1] https://github.com/gtadigital/grp-datasource/blob/152cf5c1803ee2831c44ac2cd4f3a1e2ac44df0a/samples/e21.rdf#L40