Make install script failsafe

[irapha]

If it fails, it's hard to run it again after fixing the issue that made it fail the first time.

The issues seem to be the catkin_init and rosdep init. They fail if the've already been run.

[irapha]

as a note, cole said it seems to be failing when apt-get is run sometimes, because ubuntu might be running apt-get update in the background, which puts a lock in it.

possible solution, tho jank: https://askubuntu.com/questions/132059/how-to-make-a-package-manager-wait-if-another-instance-of-apt-is-running

[irapha]

To test this: create new VM, install buzzmobile, try running a launch file.

[joshuamorton]

Alternatively, use wait in the install script, this will block until all background processes are finished.

[irapha]

bash files are async???

[joshuamorton]

I'm gonna to with 'maybe', I don't actually think it should be in this case, but if that's the problem, this should be a fix. Unless you mean that the system is auto-updating, but I don't think that's a thing that happens.

[irapha]

Actually I do think it happens. From what we read while trying to fix this issue, it seems ubuntu might start up apt-get update (or something else that locks apt-get) at a random point and that can cause the issue we found.

On Sat, Nov 12, 2016 at 11:08 PM Josh Morton notifications@github.com wrote:

I'm gonna to with 'maybe', I don't actually think it should be in this case, but if that's the problem, this should be a fix. Unless you mean that the system is auto-updating, but I don't think that's a thing that happens.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gtagency/buzzmobile/issues/126#issuecomment-260165849, or mute the thread https://github.com/notifications/unsubscribe-auth/AHC0h9fxKDpsYea5ZNZoZ85UaOoKa4nxks5q9o0mgaJpZM4KwhkJ .

[joshuamorton]

Gross, I didn't find that when I was looking around.

[irapha]

This is the main one we looked at, because the error is the same as what we got:

https://stackoverflow.com/questions/23610628/detecting-avoiding-multiple-apt-get-dpkg-installs

It works great, except in the case where some system process kicks in and starts updating APT databases in the background.. Then it fails with dpkg: error: dpkg status database is locked by another process.

[joshuamorton]

Keep in mind that that fix requires apt-get installing the tool.

On Sat, Nov 12, 2016 at 11:20 PM Raphael Gontijo Lopes < notifications@github.com> wrote:

This is the main one we looked at, because the error is the same as what we got:

https://stackoverflow.com/questions/23610628/detecting-avoiding-multiple-apt-get-dpkg-installs

It works great, except in the case where some system process kicks in and starts updating APT databases in the background.. Then it fails with dpkg: error: dpkg status database is locked by another process.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gtagency/buzzmobile/issues/126#issuecomment-260166179, or mute the thread https://github.com/notifications/unsubscribe-auth/AEz4AMRwPu9i9fmy8I9ZhEEajv8SH9JKks5q9o_ygaJpZM4KwhkJ .

[irapha]

Sure, I wasn't suggesting we use the solution in this stackoverflow. I was just showing you that it's most likely that our issue came from a background apt-get process updating databases.

[coletaylor788]

As an update, I edited the install script to use a wrapper function for apt-get that waits for other apt-get processes to terminate. It appears to not fail due to apt-get anymore. However, the application still can't be run after preparing the environment this way. I will continue looking into it.

[joshuamorton]

What issue are you hitting after build (on a clean env I assume?)

[irapha]

Sg

On Mon, Dec 5, 2016, 15:44 Cole Taylor notifications@github.com wrote:

As an update I edited the install script to use a wrapper function for apt-get that waits for other apt-get processes to terminate. It appears to be not fail due to apt-get anymore. However, the application still can't be run after preparing the environment this way. I will continue looking into it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gtagency/buzzmobile/issues/126#issuecomment-264971456, or mute the thread https://github.com/notifications/unsubscribe-auth/AHC0h3oPV5NdC2nugTQju3iLtxNdyyXoks5rFHejgaJpZM4KwhkJ .

[coletaylor788]

@joshuamorton I can't remember exactly (was about a week ago) but I believe they looked like python dependencies.

[coletaylor788]

I plan on taking another look in the next couple of days to get more information

[coletaylor788]

Here is a couple of lines from the error that I think summarizes it.

ImportError: Could not find Qt binding (looked for: 'pyqt', 'pyside'):

ImportError for 'pyqt': No module named 'sip'
ImportError for 'pyside': No module named 'PySide'

So it looks like it is looking for pyqt or pyside as the QT binding for RQT (used for mission control). pyqt has a dependency on sip which doesn't appear to be installed and pyside is also missing.

Do you know anything about this and do either of you care which binding is used? It looks like pyqt is the default binding which would probably be easier to fix.

[coletaylor788]

@iRapha @joshuamorton

[irapha]

Is rqt still failing to install? We might need to look up how to properly install it. Maybe there's an rqt_core or something we need to be depending on.

On Wed, Dec 7, 2016, 10:02 Cole Taylor notifications@github.com wrote:

@iRapha https://github.com/iRapha @joshuamorton https://github.com/joshuamorton

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/gtagency/buzzmobile/issues/126#issuecomment-265469791, or mute the thread https://github.com/notifications/unsubscribe-auth/AHC0h9nkun6wywCrvujIUYkA5YIhAq6Cks5rFsqRgaJpZM4KwhkJ .

[coletaylor788]

Yes, the problem is with rqt. I can look further into how to get it installed but want to make sure our app isn't depending on PySide vs. PyQT. Is there one that needs to be used as the binding or is either fine?

[irapha]

I believe neither of those are being explicitly used by us.

On Wed, Dec 7, 2016, 10:15 Cole Taylor notifications@github.com wrote:

Yes, the problem is with rqt. I can look further into how to get it installed but want to make sure our app isn't depending on PySide vs. PyQT. Is there one that needs to be used as the binding or is either fine?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gtagency/buzzmobile/issues/126#issuecomment-265473298, or mute the thread https://github.com/notifications/unsubscribe-auth/AHC0h3amXThi5OPV5K2hik-MhW__ZQvVks5rFs13gaJpZM4KwhkJ .

[coletaylor788]

Okay, thanks. I will proceed with the easiest way to install rqt then

[coletaylor788]

As an update, the RQT problems only occur in the virtual environment. If you run it outside the virtual environment, the issue doesn't exist.

[irapha]

This probably means that whatever is installing rqt is doing so outside of the venv.

[coletaylor788]

As an update, I think the issue may be related to Python 2 vs. 3. If I enter a python3 shell outside of the virtualenv and enter: "from qt_gui.plugin import Plugin", it gives the same import error (Sip and PySide). Howerver, it works from within the python (2) shell.

[coletaylor788]

Additionally, the import line works in python2 in the virtualenv.

[coletaylor788]

@iRapha @joshuamorton Are we supposed to be using Python 2 or 3?

[irapha]

Python3. As soon as the install script is confirmed working, we'll all get new VMs and start using python3 only. So whatever is installing pyqt is installing it for py2, which is not what we want. Maybe it's like a flag we need to set for rosdep? Or maybe we need to depend on a different version of rqt so it knows we're using py3?

[coletaylor788]

Status update at end of night:

When run with python3, it says it is missing sip. After manually compiling and installing sip with python3 (pip can't install it), it said it was missing PyQt. I installed and compiled it from source as well which removed that error. Now the error is "basestring is not defined". basestring is something only defined in Python2. It starts with rqt_gui which calls a method in qt_gui which is in python2.7.

[irapha]

So there's a slight chance we are going to have to move things to python2 (which should only be a matter of changing install script, since all the code has been locally tested in py2 anyways). I'm deferring this to @joshuamorton pls dont abandon us pls

[joshuamorton]

Indeed, it should be mostly issues in the install script, everything else should be backwards compatible (also yield from isn't supported in 2.7).

[coletaylor788]

Just let me know when y'all decide which version we plan on using. If we go with python 2, I will update the script as it should be easy to get working. Otherwise, once it is decided, I can keep troubleshooting the issues with python 3. There seems to be incompatibilities with rqt and python 3 where fixing one issue is just revealing another.

[joshuamorton]

Do py2, it'll be easier.

I hate ros.

On Mon, Dec 19, 2016, 19:26 Cole Taylor notifications@github.com wrote:

Just let me know when y'all decide which version we plan on using. If we go with python 2, I will update the script as it should be easy to get working. Otherwise, once it is decided, I can keep troubleshooting the issues with python 3. There seems to be incompatibilities with rqt and python 3 where fixing one issue is just revealing another.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gtagency/buzzmobile/issues/126#issuecomment-268118385, or mute the thread https://github.com/notifications/unsubscribe-auth/AEz4ADntyEPDCXMWzZmITEGj-Yk6c4TCks5rJyCfgaJpZM4KwhkJ .

[coletaylor788]

Okay, I'll work on it when I get time.