search

gtagency / buzzmobile

An autonomous parade float/vehicle
MIT License
18 stars 3 forks source link

Simulation #181

Closed irapha closed 7 years ago

irapha commented 7 years ago

PR not ready. Here for tracking changes

joshuamorton commented 7 years ago

Sure, one question before we do: can we get a (super barebones) RosTest that works using this branch and multiple-roscore.

nothing that needs to be merged in, but a sanity check that they will interact well.

irapha commented 7 years ago

About the test, I can write something that will literally spin up the launch file, and assert true.

I can't guarantee that we'll be able to write a test that will actually check if actuators work though, because of #161

Also I didn't want to merge #180 into this PR

joshuamorton commented 7 years ago

Not merging 180 in is fine. As long as it passed locally on some branch that's fine. I didn't even necesarilly want the test written on here, just confirmation that it works.

irapha commented 7 years ago

Oh Alright. Just tested locally in a new merged branch and it works. I'll revert the file in this PR and we can merge.

Make a note somewhere in a readme for test utils that when issues arise its a good idea to clean pyc files. I was having trouble with a test hanging (because a message wasnt being received so it just waited on stdin input forever) and cleaning pyc files fixed it.

joshuamorton commented 7 years ago

noting that this closes #182, #160, and #159