search

gtagency / buzzmobile

An autonomous parade float/vehicle
MIT License
18 stars 3 forks source link

Enable args in with_launch_file #184

Closed irapha closed 7 years ago

irapha commented 7 years ago

Closes #157

joshuamorton commented 7 years ago

your guess is as good as mine.

On Sat, Feb 18, 2017 at 9:42 PM Raphael Gontijo Lopes < notifications@github.com> wrote:

@iRapha commented on this pull request.

In buzzmobile/tests/simulation/test_gazebo_connection.py https://github.com/gtagency/buzzmobile/pull/184#discussion_r101907492:

@@ -0,0 +1,17 @@ +import unittest +import time

why didn't style check catch this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gtagency/buzzmobile/pull/184#discussion_r101907492, or mute the thread https://github.com/notifications/unsubscribe-auth/AEz4ABJeeiBYreX3XX_F_gvH0_pMPJ1oks5rd6wOgaJpZM4MEc_5 .

joshuamorton commented 7 years ago

Do we want this in this file, or in a subfolder?

irapha commented 7 years ago

In this folder. Until we have a substantial amount of simulation tests, I don't foresee a good way to separate them out in subdirectories