search

gtagency / buzzmobile

An autonomous parade float/vehicle
MIT License
18 stars 3 forks source link

Update DoCIF and use ros:indigo baseimage #202

Closed jgkamat closed 4 years ago

jgkamat commented 7 years ago

Hopefully this might affect #201

We'll see if the build works. There are a few hacky things in here, so don't merge this yet (still a WIP).

jgkamat commented 7 years ago

I would also try rebuilding master to see if it was an infra issue at all.

Could you turn on 'build forked PR's' in circleci? I reccomend not turning on buiild secrets though.

2017-04-07-204626_1492x459_scrot

irapha commented 7 years ago

Done! Thanks for the help Jay!

I did try rebuilding master. I mentioned it didn't work here: https://github.com/gtagency/buzzmobile/commit/34d006afe8483439912d9c1c890cb39a16daf99a

irapha commented 7 years ago

Actually I'm gonna try rebuilding again

jgkamat commented 7 years ago

Hey, it looks like the CI magically started working again (so it was probably a bug in circleci or a dockerimage that was fixed). This branch does have a few improvements though (such as pulling from ros:indigo instead of installing ros for every build), so you can use it if you want. Let me know if you want it cleaned up. :P

irapha commented 7 years ago

Yeah I saw it was fixed. Like 2 days after you last pushed to this PR I rebuilt master and it passed :)

I am fine with this PR, let me just make a comment or two and if you have some time to clean it up I'd appresh <3

jgkamat commented 7 years ago

I'm pretty confused why preventing rosdep init would cause it to timeout (afaik, the other way is failing, and not doing anything). I'll take a closer look at that later.

jgkamat commented 7 years ago

The tests actually did run (see the circleci build logs). Forked PR's don't get secrets (doing so would be a security risk), so that's why the individual status tokens aren't updating.

I'll fix up the PR and merge master into it. This does not help with #192 in any way though (as far as I can tell). I'll also trash that 'bump' commit.

joshuamorton commented 7 years ago

Ah yeah, then LGTM.