gtalarico / pyairtable

Python Api Client for Airtable
https://pyairtable.readthedocs.io
MIT License
765 stars 138 forks source link

Fix #169 get record id by field id as well. #173

Closed NicoHood closed 2 years ago

NicoHood commented 2 years ago

Enables all rest options for record id requests

gtalarico commented 2 years ago

Thanks

NicoHood commented 2 years ago

Thank you as well! Would you mind giving it a new tag? :angel:

NicoHood commented 2 years ago

I just tried to install by commit, but that does not seem to work for me. I still have 1.2.0 installed, although the installation returns no error.

pip install --user git+https://github.com/gtalarico/pyairtable.git@bbe6e6a413579fb62a7103f4eaca64075e729225
gtalarico commented 2 years ago

@NicoHood not sure what could be wrong but works fine for here. Should still be 1.2.0 since that commit does not have a version bump but you can see the _get_record signature is updated

$ python -m venv
$ activate
.venv ❯ pip install git+https://github.com/gtalarico/pyairtable.git@bbe6e6a413579fb62a7103f4eaca64075e729225

Collecting git+https://github.com/gtalarico/pyairtable.git@bbe6e6a413579fb62a7103f4eaca64075e729225
  Cloning https://github.com/gtalarico/pyairtable.git (to revision bbe6e6a413579fb62a7103f4eaca64075e729225) to 

...

.venv ❯ cat .venv/lib/python3.8/site-packages/pyairtable/api/abstract.py | grep "_get_record("
    def _get_record(self, base_id: str, table_name: str, record_id: str, **options) -> dict:

In any case, release this and a few other changes packaged in #174 as 1.3.0 https://pypi.org/project/pyairtable/#history